From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read, write}_fw() docs
Date: Wed, 18 Nov 2026 11:45:56 +0200 [thread overview]
Message-ID: <71b5e4616f87ef83a2997ad6813f609f2e011405@intel.com> (raw)
In-Reply-To: <avcfS-j_eUkkswiM@intel.com>
On Fri, 13 Nov 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Nov 13, 2026 at 04:12:51PM +0200, Jani Nikula wrote:
>> On Fri, 13 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > Include a bit more guidance on when to use or not use
>> > intel_de_{read,write}_fw(), and what the extra caveats
>> > are.
>> >
>> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_de.h | 13 ++++++++++---
>> > 1 file changed, 10 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
>> > index a6dcb91b36f2..2c469a2d6a20 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_de.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_de.h
>> > @@ -87,12 +87,19 @@ int intel_de_wait_for_clear_ms(struct intel_display *display, intel_reg_t reg,
>> > u32 mask, unsigned int timeout_ms);
>> >
>> > /*
>> > - * Unlocked mmio-accessors, think carefully before using these.
>> > + * Unlocked mmio-accessors, think carefully before using these. Generally only
>> > + * highly performance sensitive code should use these (eg. vblank evade critical
>> > + * section, or interrupt handlers).
>> > *
>> > * Certain architectures will die if the same cacheline is concurrently accessed
>> > - * by different clients (e.g. on Ivybridge). Access to registers should
>> > - * therefore generally be serialised, by either the dev_priv->uncore.lock or
>> > + * by different clients (e.g. on Ivybridge/Haswell). Access to registers should
>> > + * therefore generally be serialised, by either the display->mmio.lock or
>> > * a more localised lock guarding all access to that bank of registers.
>> > + *
>> > + * DMC wakelock will not be taken by these. It must be done manually,
>> > + * if needed.
>>
>> Is there anything we could mention here about what "if needed" really
>> means?
>
> "See intel_dmc_wl.c which registers need the wakelock."
> ?
Ack.
>
>>
>> Regardless,
>>
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>
>>
>> > + *
>> > + * These will also skip the mmio_debug unclaimed register detection.
>> > */
>> > u32 intel_de_read_fw(struct intel_display *display, intel_reg_t reg);
>> > void intel_de_write_fw(struct intel_display *display, intel_reg_t reg, u32 val);
>>
>> --
>> Jani Nikula, Intel
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-11-18 9:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 13:43 [PATCH 0/8] drm/{i915, xe}: Make unclaimed mmio detection lockless and enable it for xe Ville Syrjala
2026-11-13 13:43 ` [PATCH 1/8] drm/i915/de: Uninline intel_de_{read,write}_fw() Ville Syrjala
2026-11-13 14:11 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read,write}_fw() docs Ville Syrjala
2026-11-13 14:12 ` [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read, write}_fw() docs Jani Nikula
2026-11-13 14:31 ` Ville Syrjälä
2026-11-18 9:45 ` Jani Nikula [this message]
2026-11-13 13:43 ` [PATCH 3/8] drm/i915/de: Flatten the unclaimed mmio code Ville Syrjala
2026-11-13 14:25 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 4/8] drm/i915/de: Make mmio_debug lockless Ville Syrjala
2026-11-13 16:30 ` Ville Syrjälä
2026-11-18 9:46 ` Jani Nikula
2026-11-18 10:04 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 5/8] drm/i915/de: Optimize the mmio_debug checks in intel_de_{read, write}() Ville Syrjala
2026-11-18 10:10 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 6/8] drm/i915/de: Make display registers unlocked for TGL+ on i915 Ville Syrjala
2026-11-18 10:11 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 7/8] drm/xe: Enable unclaimed register detection on xe Ville Syrjala
2026-11-18 10:14 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 8/8] drm/i915/de: Nuke driver_is_i915() Ville Syrjala
2026-11-18 10:15 ` Jani Nikula
2026-11-13 14:33 ` ✗ CI.checkpatch: warning for drm/{i915, xe}: Make unclaimed mmio detection lockless and enable it for xe Patchwork
2026-11-13 14:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-13 14:52 ` ✗ CI.checksparse: warning " Patchwork
2026-11-13 15:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-11-13 16:41 ` Ville Syrjälä
2026-11-14 0:50 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b5e4616f87ef83a2997ad6813f609f2e011405@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox