From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 6/8] drm/i915/de: Make display registers unlocked for TGL+ on i915
Date: Wed, 18 Nov 2026 12:11:49 +0200 [thread overview]
Message-ID: <e6b11fe164dcf28f719f020bcdbbc0d592acc945@intel.com> (raw)
In-Reply-To: <20261113134355.14579-7-ville.syrjala@linux.intel.com>
On Fri, 13 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Now that the unclaimed register detection should survive
> without the lock there should be no reason to use the lock
> on most platforms.
>
> Start by weaning TGL+ off the lock. Since some people have
> been using the (lockless) xe driver on TGL/etc. it should
> be fairly well established that serializing all register
> accesses is not needed on these platforms.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_de.c | 26 +++++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_de.c b/drivers/gpu/drm/i915/display/intel_de.c
> index 81fd1569bb65..9e2f6ce0ff7e 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.c
> +++ b/drivers/gpu/drm/i915/display/intel_de.c
> @@ -482,6 +482,26 @@ static const struct intel_mmio_funcs vlv_mmio_funcs = {
> .check_for_unclaimed_mmio_needs_lock = true,
> };
>
> +#define TGL_MMIO_FLAGS __MMIO_UNCLAIMED
> +
> +static u32 tgl_mmio_read(struct intel_display *display, intel_reg_t reg)
> +{
> + return __intel_de_read(display, reg, TGL_MMIO_FLAGS);
> +}
> +
> +static void tgl_mmio_write(struct intel_display *display, intel_reg_t reg, u32 val)
> +{
> + __intel_de_write(display, reg, val, TGL_MMIO_FLAGS);
> +}
> +
> +#undef TGL_MMIO_FLAGS
> +
> +static const struct intel_mmio_funcs tgl_mmio_funcs = {
> + .read = tgl_mmio_read,
> + .write = tgl_mmio_write,
> + .check_for_unclaimed_mmio = hsw_check_for_unclaimed_mmio,
> +};
> +
> #define LNL_MMIO_FLAGS __MMIO_WAKELOCK
>
> static u32 lnl_mmio_read(struct intel_display *display, intel_reg_t reg)
> @@ -522,8 +542,10 @@ void intel_de_init(struct intel_display *display)
> * rid of driver_is_i915().
> */
> if (driver_is_i915()) {
> - if (DISPLAY_VER(display) >= 9 ||
> - display->platform.broadwell || display->platform.haswell)
> + if (DISPLAY_VER(display) >= 12)
> + display->mmio.funcs = &tgl_mmio_funcs;
> + else if (DISPLAY_VER(display) >= 9 ||
> + display->platform.broadwell || display->platform.haswell)
> display->mmio.funcs = &hsw_mmio_funcs;
> else if (display->platform.valleyview || display->platform.cherryview)
> display->mmio.funcs = &vlv_mmio_funcs;
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-11-18 10:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 13:43 [PATCH 0/8] drm/{i915, xe}: Make unclaimed mmio detection lockless and enable it for xe Ville Syrjala
2026-11-13 13:43 ` [PATCH 1/8] drm/i915/de: Uninline intel_de_{read,write}_fw() Ville Syrjala
2026-11-13 14:11 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read,write}_fw() docs Ville Syrjala
2026-11-13 14:12 ` [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read, write}_fw() docs Jani Nikula
2026-11-13 14:31 ` Ville Syrjälä
2026-11-18 9:45 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 3/8] drm/i915/de: Flatten the unclaimed mmio code Ville Syrjala
2026-11-13 14:25 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 4/8] drm/i915/de: Make mmio_debug lockless Ville Syrjala
2026-11-13 16:30 ` Ville Syrjälä
2026-11-18 9:46 ` Jani Nikula
2026-11-18 10:04 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 5/8] drm/i915/de: Optimize the mmio_debug checks in intel_de_{read, write}() Ville Syrjala
2026-11-18 10:10 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 6/8] drm/i915/de: Make display registers unlocked for TGL+ on i915 Ville Syrjala
2026-11-18 10:11 ` Jani Nikula [this message]
2026-11-13 13:43 ` [PATCH 7/8] drm/xe: Enable unclaimed register detection on xe Ville Syrjala
2026-11-18 10:14 ` Jani Nikula
2026-11-13 13:43 ` [PATCH 8/8] drm/i915/de: Nuke driver_is_i915() Ville Syrjala
2026-11-18 10:15 ` Jani Nikula
2026-11-13 14:33 ` ✗ CI.checkpatch: warning for drm/{i915, xe}: Make unclaimed mmio detection lockless and enable it for xe Patchwork
2026-11-13 14:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-13 14:52 ` ✗ CI.checksparse: warning " Patchwork
2026-11-13 15:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-11-13 16:41 ` Ville Syrjälä
2026-11-14 0:50 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b11fe164dcf28f719f020bcdbbc0d592acc945@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox