Re: [PATCH v5 3/4] drm/xe/vf: Disallow setting wedged_mode=2

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 14.05.2025 12:11, Lukasz Laguna wrote:
> In wedged_mode=2, engine resets need to be disabled, which requires
                ^^
maybe we can name the mode instead using its value?

> changing the GuC reset policy. VFs are not permitted to do that.
> 
> Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index a8470221ff85..7dfc39dd4c9c 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1189,6 +1189,10 @@ int xe_device_validate_wedged_mode(struct xe_device *xe, unsigned int mode)
>  	if (mode > XE_WEDGED_MODE_UPON_ANY_HANG) {
>  		drm_dbg(&xe->drm, "wedged_mode: invalid value (%u)\n", mode);
>  		return -EINVAL;
> +	} else if (mode == XE_WEDGED_MODE_UPON_ANY_HANG && IS_SRIOV_VF(xe)) {
> +		drm_dbg(&xe->drm, "wedged_mode: unsupported mode (%u) for %s\n", mode,

maybe it's worth to add xe_wedge_mode_to_string() as it could be also
used in patch 1/4

> +			xe_sriov_mode_to_string(xe_device_sriov_mode(xe)));
> +		return -EPERM;
>  	}
>  
>  	return 0;