From: Lukasz Laguna <lukasz.laguna@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, rodrigo.vivi@intel.com,
matthew.brost@intel.com, lukasz.laguna@intel.com
Subject: [PATCH v5 0/4] drm/xe: Improve wedged mode handling
Date: Wed, 14 May 2025 12:11:20 +0200 [thread overview]
Message-ID: <20250514101124.12437-1-lukasz.laguna@intel.com> (raw)
Prevent the VF from attempting to update the GuC reset policy when
changing the wedged mode, as this operation is not supported on VFs.
Additionally, validate the wedged_mode module parameter input, update
the internal wedged.mode state only on success, and allow setting
wedged_mode=2 only in debug builds if running as PF.
v1: https://patchwork.freedesktop.org/series/148214/#rev1
v2: Replace magic numbers with definitions (Matt, Michal)
Use helper to sanitize wedged_mode (Michal)
Change debug messages (Michal)
Reorder patches (Michal)
Add fixes tag (Matt)
v3: Rename xe_device_wedged_mode_validate to
xe_device_validate_wedged_mode (Michal)
Make enum nameless (Michal)
Add default field in enum (Michal)
Change names of enum fields to match modparam description (Michal)
v4: Fix GuC reset policy update
Replace missing magic numbers with definitions
Update debug message
v5: Remove old rb-s from the patch that changed
Lukasz Laguna (4):
drm/xe: Validate wedged_mode parameter and define enum for modes
drm/xe: Don't update wedged mode in case of an error
drm/xe/vf: Disallow setting wedged_mode=2
drm/xe/pf: Allow wedged_mode=2 only in debug config
drivers/gpu/drm/xe/xe_debugfs.c | 13 ++++++------
drivers/gpu/drm/xe/xe_device.c | 30 ++++++++++++++++++++++++++--
drivers/gpu/drm/xe/xe_device.h | 1 +
drivers/gpu/drm/xe/xe_device_types.h | 7 ++++++-
drivers/gpu/drm/xe/xe_guc_ads.c | 9 +++++----
drivers/gpu/drm/xe/xe_guc_ads.h | 3 ++-
drivers/gpu/drm/xe/xe_guc_capture.c | 3 ++-
drivers/gpu/drm/xe/xe_guc_submit.c | 6 +++---
drivers/gpu/drm/xe/xe_module.c | 5 +++--
drivers/gpu/drm/xe/xe_module.h | 2 +-
10 files changed, 58 insertions(+), 21 deletions(-)
--
2.40.0
next reply other threads:[~2025-05-14 10:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 10:11 Lukasz Laguna [this message]
2025-05-14 10:11 ` [PATCH v5 1/4] drm/xe: Validate wedged_mode parameter and define enum for modes Lukasz Laguna
2025-05-14 20:18 ` Michal Wajdeczko
2025-05-14 10:11 ` [PATCH v5 2/4] drm/xe: Don't update wedged mode in case of an error Lukasz Laguna
2025-05-14 20:28 ` Michal Wajdeczko
2025-05-14 20:43 ` Michal Wajdeczko
2025-05-14 10:11 ` [PATCH v5 3/4] drm/xe/vf: Disallow setting wedged_mode=2 Lukasz Laguna
2025-05-14 20:34 ` Michal Wajdeczko
2025-05-14 10:11 ` [PATCH v5 4/4] drm/xe/pf: Allow wedged_mode=2 only in debug config Lukasz Laguna
2025-05-14 20:39 ` Michal Wajdeczko
2025-05-14 22:10 ` ✓ CI.Patch_applied: success for drm/xe: Improve wedged mode handling (rev5) Patchwork
2025-05-14 22:10 ` ✓ CI.checkpatch: " Patchwork
2025-05-14 22:12 ` ✓ CI.KUnit: " Patchwork
2025-05-14 22:22 ` ✓ CI.Build: " Patchwork
2025-05-14 22:24 ` ✗ CI.Hooks: failure " Patchwork
2025-05-14 22:26 ` ✓ CI.checksparse: success " Patchwork
2025-05-14 22:59 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-15 7:36 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514101124.12437-1-lukasz.laguna@intel.com \
--to=lukasz.laguna@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox