From: Lukasz Laguna <lukasz.laguna@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, rodrigo.vivi@intel.com,
matthew.brost@intel.com, lukasz.laguna@intel.com
Subject: [PATCH v5 4/4] drm/xe/pf: Allow wedged_mode=2 only in debug config
Date: Wed, 14 May 2025 12:11:24 +0200 [thread overview]
Message-ID: <20250514101124.12437-5-lukasz.laguna@intel.com> (raw)
In-Reply-To: <20250514101124.12437-1-lukasz.laguna@intel.com>
The GuC reset policy is global, so changing it on PF can impact running
VFs. To avoid unintended side effects, setting wedged_mode=2 on the PF
is restricted to debug builds only.
Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 7dfc39dd4c9c..f23d8236bddc 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -1189,7 +1189,8 @@ int xe_device_validate_wedged_mode(struct xe_device *xe, unsigned int mode)
if (mode > XE_WEDGED_MODE_UPON_ANY_HANG) {
drm_dbg(&xe->drm, "wedged_mode: invalid value (%u)\n", mode);
return -EINVAL;
- } else if (mode == XE_WEDGED_MODE_UPON_ANY_HANG && IS_SRIOV_VF(xe)) {
+ } else if (mode == XE_WEDGED_MODE_UPON_ANY_HANG && (IS_SRIOV_VF(xe) ||
+ (IS_SRIOV_PF(xe) && !IS_ENABLED(CONFIG_DRM_XE_DEBUG)))) {
drm_dbg(&xe->drm, "wedged_mode: unsupported mode (%u) for %s\n", mode,
xe_sriov_mode_to_string(xe_device_sriov_mode(xe)));
return -EPERM;
--
2.40.0
next prev parent reply other threads:[~2025-05-14 10:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 10:11 [PATCH v5 0/4] drm/xe: Improve wedged mode handling Lukasz Laguna
2025-05-14 10:11 ` [PATCH v5 1/4] drm/xe: Validate wedged_mode parameter and define enum for modes Lukasz Laguna
2025-05-14 20:18 ` Michal Wajdeczko
2025-05-14 10:11 ` [PATCH v5 2/4] drm/xe: Don't update wedged mode in case of an error Lukasz Laguna
2025-05-14 20:28 ` Michal Wajdeczko
2025-05-14 20:43 ` Michal Wajdeczko
2025-05-14 10:11 ` [PATCH v5 3/4] drm/xe/vf: Disallow setting wedged_mode=2 Lukasz Laguna
2025-05-14 20:34 ` Michal Wajdeczko
2025-05-14 10:11 ` Lukasz Laguna [this message]
2025-05-14 20:39 ` [PATCH v5 4/4] drm/xe/pf: Allow wedged_mode=2 only in debug config Michal Wajdeczko
2025-05-14 22:10 ` ✓ CI.Patch_applied: success for drm/xe: Improve wedged mode handling (rev5) Patchwork
2025-05-14 22:10 ` ✓ CI.checkpatch: " Patchwork
2025-05-14 22:12 ` ✓ CI.KUnit: " Patchwork
2025-05-14 22:22 ` ✓ CI.Build: " Patchwork
2025-05-14 22:24 ` ✗ CI.Hooks: failure " Patchwork
2025-05-14 22:26 ` ✓ CI.checksparse: success " Patchwork
2025-05-14 22:59 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-15 7:36 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514101124.12437-5-lukasz.laguna@intel.com \
--to=lukasz.laguna@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox