Re: [RFC PATCH v3 3/3] drm/xe: use XE_RAS_WEDGED macro in xe_device_declare_wedged

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 21-06-2026 01:09 am, Michal Wajdeczko wrote:
>
> On 6/17/2026 12:47 PM, Mallesh Koujalagi wrote:
>> Replace the open-coded drm_err() call with XE_RAS_WEDGED()
>> macro so that wedge events are reported through the unified
>> RAS/SIG logging path with a consistent format, CPER severity,
>> and errno.
>>
>> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
>> ---
>> v2:
>> - Rebase.
>>
>> v3:
>> - Update message in xe_ras_log_wedged().
>> ---
>>   drivers/gpu/drm/xe/xe_device.c | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
>> index 089872507bdd..8284578b9156 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -61,6 +61,7 @@
>>   #include "xe_psmi.h"
>>   #include "xe_pxp.h"
>>   #include "xe_query.h"
>> +#include "xe_ras_log.h"
>>   #include "xe_shrinker.h"
>>   #include "xe_soc_remapper.h"
>>   #include "xe_survivability_mode.h"
>> @@ -1424,12 +1425,12 @@ void xe_device_declare_wedged(struct xe_device *xe)
>>   	if (!atomic_xchg(&xe->wedged.flag, 1)) {
>>   		xe->needs_flr_on_fini = true;
>>   		xe_pm_runtime_get_noresume(xe);
>> -		drm_err(&xe->drm,
>> -			"CRITICAL: Xe has declared device %s as wedged.\n"
>> -			"IOCTLs and executions are blocked.\n"
>> -			"For recovery procedure, refer to https://docs.kernel.org/gpu/drm-uapi.html#device-wedging\n"
>> -			"Please file a _new_ bug report at https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n",
>> -			dev_name(xe->drm.dev));
>> +		xe_ras_log_wedged(xe, -EIO,
> who really cares about the errno if machine will only look at class and severity?
We need errno to encode the driver-side failure and same stuff need to 
update in cper/tracefs.
>
> if relevant for deep-dive analysis, it should be printed as part of the regular message
Yes, we need to print details since device is declared as wedged.
>
>> +				  "CRITICAL: Xe has declared device %s as wedged.\n"
> hmm, so now we will have all this in one log line:
>
> 	*ERROR*
> 	[xe-err]
> 	Severity = FATAL
> 	CRITICAL:
>
> and full message like:
>
> 	<3> [0.028976] xe 0000:03:00.0: [drm] *ERROR* [xe-err] SIG_ID = 2 Severity = FATAL Location = device Errno = -5  Xe driver declared device 0000:03:00.0 as wedged. ...
Yes, Arch team is inline with that format.
>
>> +				  "IOCTLs and executions are blocked.\n"
>> +				  "For recovery procedure, refer to https://docs.kernel.org/gpu/drm-uapi.html#device-wedging\n"
>> +				  "Please file a _new_ bug report at https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n",
>> +				  dev_name(xe->drm.dev));
> compare with:
>
> 	xe_err_fatal(xe, WEDGED, "Xe driver declared device as wedged. ...")
> and
> 	<3> [0.028976] xe 0000:03:00.0: [drm] *ERROR* [WEDGED] *FATAL* Xe driver declared device as wedged.
>
Since macro is based on severity what happen when we have PROBE has 
different severity? so we defined macro based on component.

Thanks,

-/Mallesh

>>   	}
>>   
>>   	for_each_gt(gt, xe, id)