Re: [RFC PATCH v3 1/3] drm/xe: Add error Signature IDs for RAS logging

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2806 bytes --]


On 19-06-2026 11:18 am, Tauro, Riana wrote:
>
> On 17-06-2026 16:17, Mallesh Koujalagi wrote:
>> Every GPU fault needs a stable numeric label so monitoring tools can
>
> GPU fault does not need a label. This patch introduces so it's easy 
> for tools /script to monitor.
>
You are right. I will update this in the next revision.

>> identify what went wrong without parsing log text. Add xe_sig_ids.h
>> which defines those labels, called SIG_IDs.
>>
>> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
>> ---
>> v3:
>> - Add HW SIG IDS details. (Riana)
>> ---
>>   drivers/gpu/drm/xe/xe_sig_ids.h | 29 +++++++++++++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>   create mode 100644 drivers/gpu/drm/xe/xe_sig_ids.h
>>
>> diff --git a/drivers/gpu/drm/xe/xe_sig_ids.h 
>> b/drivers/gpu/drm/xe/xe_sig_ids.h
>> new file mode 100644
>> index 000000000000..7badd0d7ad72
>> --- /dev/null
>> +++ b/drivers/gpu/drm/xe/xe_sig_ids.h
>> @@ -0,0 +1,29 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2026 Intel Corporation
>> + */
>> +
>> +#ifndef _XE_SIG_IDS_H_
>> +#define _XE_SIG_IDS_H_
>
> Document would be more relevant here
>
Ack, I'll move here.
>> +
>> +/*
>> + * Driver SIG_IDs
>> + */
>> +#define XE_SIG_PROBE            1  /* FATAL: probe failed */
>> +#define XE_SIG_WEDGED            2  /* FATAL: device wedged */
>> +#define XE_SIG_SURVIVABILITY        3  /* FATAL: survivability mode */
>> +#define XE_SIG_FW            4  /* RECOVERABLE: 
>> GuC/HuC/UC/GSC/CSC/PCODE */
>> +#define XE_SIG_GT_TDR            5  /* RECOVERABLE: engine hang / 
>> reset */
>> +#define XE_SIG_MEM_FAULT        6  /* RECOVERABLE: VM bind, page 
>> fault, GTT */
>> +#define XE_SIG_IO_BUS            7  /* RECOVERABLE: runtime 
>> PCIe/IOMMU/MMIO */
>> +
>> +/*
>> + * HW SIG_IDs
>
> Acronym needed? Mention Hardware error
>
Good point. I will update the comment to explicitly mention “Hardware 
errors” in the next revision.

>> + */
>> +#define XE_SIG_HW_DEVICE_MEMORY        8  /* Device memory errors 
>> (e.g. ECC) */
>
> example not needed. If required please define
>
Agreed. I will drop the example and keep the comment concise

>> +#define XE_SIG_HW_CORE_COMPUTE        9 /* Compute/shader core 
>> errors */
>> +#define XE_SIG_HW_PCIE            10 /* PCIe interface errors */
>> +#define XE_SIG_HW_FABRIC        11 /* On-package fabric errors */
> on-package?

It refers to the high speed interconnect between dies/tiles within the 
same GPU.

I'll make the comment clearer in next revision.

Thanks,

-/Mallesh

>
> Thanks
> Riana
>
>
>> +#define XE_SIG_HW_SOC_INTERNAL        12 /* SoC-internal errors */
>> +
>> +#endif /* _XE_SIG_IDS_H_ */

[-- Attachment #2: Type: text/html, Size: 5983 bytes --]