Re: [PATCH v2 2/3] drm/i915/display: Add definition for wcl as subplatform

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Dnyaneshwar Bhadane (2025-09-19 13:22:32-03:00)
>Update the device definition structs for adding wildcat lake as
>subplatfrom of pantherlake.

I think the commit message is missing the reason why we are doing this.
I would replace the above paragraph with something like:

    "We will need to differentiate between WCL and PTL in
    intel_encoder_is_c10phy(). Since WCL and PTL use the same display
    architecture, let's define WCL as a subplatform of PTL to allow the
    differentiation."

>
>Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_display_device.c | 12 ++++++++++++
> drivers/gpu/drm/i915/display/intel_display_device.h |  4 +++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
>index a9a36176096f..84aa6b6384da 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_device.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
>@@ -1379,6 +1379,11 @@ static const u16 mtl_u_ids[] = {
>         0
> };
> 
>+static const u16 wcl_ids[] = {
>+        INTEL_WCL_IDS(ID),
>+        0
>+};
>+

To be consistent with the other subplatform device id lists, we probably
want to move this to be just before the definition of ptl_desc.

With this addressed and the commit message rephrased,

    Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

--
Gustavo Sousa

> /*
>  * Do not initialize the .info member of the platform desc for GMD ID based
>  * platforms. Their display will be probed automatically based on the IP version
>@@ -1406,6 +1411,13 @@ static const struct platform_desc bmg_desc = {
> 
> static const struct platform_desc ptl_desc = {
>         PLATFORM(pantherlake),
>+        .subplatforms = (const struct subplatform_desc[]) {
>+                {
>+                        SUBPLATFORM(pantherlake, wildcatlake),
>+                        .pciidlist = wcl_ids,
>+                },
>+                {},
>+        }
> };
> 
> __diag_pop();
>diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>index 1f091fbcd0ec..0e062753cf9b 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_device.h
>+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>@@ -101,7 +101,9 @@ struct pci_dev;
>         /* Display ver 14.1 (based on GMD ID) */ \
>         func(battlemage) \
>         /* Display ver 30 (based on GMD ID) */ \
>-        func(pantherlake)
>+        func(pantherlake) \
>+        func(pantherlake_wildcatlake)
>+
> 
> #define __MEMBER(name) unsigned long name:1;
> #define __COUNT(x) 1 +
>-- 
>2.51.0
>