Re: [PATCH v2 1/2] drm/xe/tests/pci: Convert GT count check to general device check

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Gustavo Sousa (2025-10-20 20:45:56-03:00)
>We already have check_graphics_ip() and check_media_ip() as general
>functions to check the IP descriptors.  The check in
>check_platform_gt_count() is simple enough such that we can convert the
>function to a more general device check.  In an upcoming change, we will
>also add some checks for other members of struct xe_device_desc. As
>such, rename check_platform_gt_count() to check_platform_desc().
>
>While at it, use inline (unsigned int) casting of max_gt_per_tile to
>keep checks for each member localized; and use KUNIT_EXPECT_*() variants
>of the macros to allow multiple issues to be reported.
>
>v2:
>  - Use (int) instead of (unsigned int) casting. (Michal)

Whoops. It's actually the other way around.  I'll fix it when applying.

>  - Use KUNIT_EXPECT_*() instead of UNIT_ASSERT_*() macros. (Michal)
>
>Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>---
> drivers/gpu/drm/xe/tests/xe_pci_test.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/tests/xe_pci_test.c b/drivers/gpu/drm/xe/tests/xe_pci_test.c
>index 37b344df2dc3..4ba2fb93c9de 100644
>--- a/drivers/gpu/drm/xe/tests/xe_pci_test.c
>+++ b/drivers/gpu/drm/xe/tests/xe_pci_test.c
>@@ -44,21 +44,20 @@ static void check_media_ip(struct kunit *test)
>         KUNIT_ASSERT_EQ(test, mask, 0);
> }
> 
>-static void check_platform_gt_count(struct kunit *test)
>+static void check_platform_desc(struct kunit *test)
> {
>         const struct pci_device_id *pci = test->param_value;
>         const struct xe_device_desc *desc =
>                 (const struct xe_device_desc *)pci->driver_data;
>-        int max_gt = desc->max_gt_per_tile;
> 
>-        KUNIT_ASSERT_GT(test, max_gt, 0);
>-        KUNIT_ASSERT_LE(test, max_gt, XE_MAX_GT_PER_TILE);
>+        KUNIT_EXPECT_GT(test, (unsigned int)desc->max_gt_per_tile, 0);
>+        KUNIT_EXPECT_LE(test, (unsigned int)desc->max_gt_per_tile, XE_MAX_GT_PER_TILE);
> }
> 
> static struct kunit_case xe_pci_tests[] = {
>         KUNIT_CASE_PARAM(check_graphics_ip, xe_pci_graphics_ip_gen_param),
>         KUNIT_CASE_PARAM(check_media_ip, xe_pci_media_ip_gen_param),
>-        KUNIT_CASE_PARAM(check_platform_gt_count, xe_pci_id_gen_param),
>+        KUNIT_CASE_PARAM(check_platform_desc, xe_pci_id_gen_param),
>         {}
> };
> 
>
>-- 
>2.51.0
>