Re: [PATCH v2 1/2] drm/xe/tests/pci: Convert GT count check to general device check

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Lucas De Marchi (2025-10-20 23:07:47-03:00)
>On Mon, Oct 20, 2025 at 08:57:44PM -0300, Gustavo Sousa wrote:
>>Quoting Gustavo Sousa (2025-10-20 20:45:56-03:00)
>>>We already have check_graphics_ip() and check_media_ip() as general
>>>functions to check the IP descriptors.  The check in
>>>check_platform_gt_count() is simple enough such that we can convert the
>>>function to a more general device check.  In an upcoming change, we will
>>>also add some checks for other members of struct xe_device_desc. As
>>>such, rename check_platform_gt_count() to check_platform_desc().
>>>
>>>While at it, use inline (unsigned int) casting of max_gt_per_tile to
>>>keep checks for each member localized; and use KUNIT_EXPECT_*() variants
>>>of the macros to allow multiple issues to be reported.
>>>
>>>v2:
>>>  - Use (int) instead of (unsigned int) casting. (Michal)
>>
>>Whoops. It's actually the other way around.  I'll fix it when applying.
>
>or just follow the kernel docs[1] and don't add changelogs to the patch
>themselves.

Okay.  Removed them.

By the way, do we have instructions documented somewhere about the
general policy for drm (or maybe also i915 and i915/display)?

By doing calling the following git log on drm-tip

    git log --no-merges -- drivers/gpu/drm/drm_'*'

I see a mixture of styles: some commits include the changelog and others
don't. For some of the latter, we can see the the changelog is in the
patch email, below the "---" line.

If there is some documentation on the subject on the DRM-level, then
perhaps we would need to list xe as one of the drivers that opted out.

>
>>
>>>  - Use KUNIT_EXPECT_*() instead of UNIT_ASSERT_*() macros. (Michal)
>>>
>>>Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>
>Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Thanks!

--
Gustavo Sousa

>
>Lucas De Marchi
>
>[1] https://docs.kernel.org/process/submitting-patches.html#commentary