Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/xe: Use intel_display_gse_irq_handler()
Date: Mon, 09 Nov 2026 14:22:58 +0200	[thread overview]
Message-ID: <1c47a450915aef0eefdedf56656fd77359c7f76c@intel.com> (raw)
In-Reply-To: <avG5Zm_5f_q8Kdgk@intel.com>

On Mon, 09 Nov 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Nov 09, 2026 at 02:05:08PM +0200, Jani Nikula wrote:
>> On Mon, 09 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > Replace the direct intel_opregion_asle_intr() call with the
>> > new intel_display_gse_irq_handler() abstraction. We don't
>> > want to leak random opregion symbols out from the display
>> > code.
>> 
>> This depends on [1] which I don't think is merged yet?
>
> It's in drm-intel-next. Need to remember to postpone this
> one when pushing the rest to drm-xe-next.

So it is, my bad.

I think patch 4 is independent of 1-3, and could be merged right away
via drm-intel-next, as is usual for display patches. Right?

BR,
Jani.

>
>> 
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> 
>> [1] https://lore.kernel.org/r/20261105203427.8696-3-ville.syrjala@linux.intel.com
>> 
>> >
>> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > ---
>> >  drivers/gpu/drm/xe/display/xe_display.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
>> > index 21692408f9be..0236f69a0f88 100644
>> > --- a/drivers/gpu/drm/xe/display/xe_display.c
>> > +++ b/drivers/gpu/drm/xe/display/xe_display.c
>> > @@ -220,7 +220,7 @@ void xe_display_gse_irq_handler(struct xe_device *xe, u32 gu_misc_iir)
>> >  		return;
>> >  
>> >  	if (gu_misc_iir & GU_MISC_GSE)
>> > -		intel_opregion_asle_intr(display);
>> > +		intel_display_gse_irq_handler(display);
>> >  }
>> >  
>> >  void xe_display_irq_reset(struct xe_device *xe)
>> 
>> -- 
>> Jani Nikula, Intel

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-11-09 12:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 11:45 [PATCH 0/4] drm/xe: Clean up the GU_MISC irq handling Ville Syrjala
2026-11-09 11:45 ` [PATCH 1/4] drm/xe: s/xe_display_irq_enable()/xe_display_gse_irq_handler()/ Ville Syrjala
2026-11-09 11:59   ` Jani Nikula
2026-11-09 11:45 ` [PATCH 2/4] drm/xe: Extract xe_gu_misc_irq_{postinstall,reset}() Ville Syrjala
2026-11-09 12:00   ` Jani Nikula
2026-11-09 11:45 ` [PATCH 3/4] drm/xe: Only enable the GSE interrupt when display needs it Ville Syrjala
2026-11-09 12:03   ` Jani Nikula
2026-11-09 11:45 ` [PATCH 4/4] drm/xe: Use intel_display_gse_irq_handler() Ville Syrjala
2026-11-09 11:51   ` sashiko-bot
2026-11-09 12:28     ` Ville Syrjälä
2026-11-09 12:05   ` Jani Nikula
2026-11-09 12:15     ` Ville Syrjälä
2026-11-09 12:22       ` Jani Nikula [this message]
2026-11-09 12:34         ` Ville Syrjälä
2026-11-09 14:10 ` ✓ CI.KUnit: success for drm/xe: Clean up the GU_MISC irq handling Patchwork
2026-11-09 14:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-09 16:28 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c47a450915aef0eefdedf56656fd77359c7f76c@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox