Re: [PATCH 2/4] drm/xe: Extract xe_gu_misc_irq_{postinstall,reset}()

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 09 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the GU_MISC interrupt setup a bit nicer by extracting
> it to its own functions.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_irq.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 320fc64e7d4f..7c39d7a3cf8a 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -645,6 +645,12 @@ static void vf_irq_reset(struct xe_device *xe)
>  	}
>  }
>  
> +static void xe_gu_misc_irq_reset(struct xe_device *xe)
> +{
> +	mask_and_disable(xe_device_get_root_tile(xe),
> +			 GU_MISC_IRQ_OFFSET);
> +}
> +
>  static void xe_irq_reset(struct xe_device *xe)
>  {
>  	struct xe_tile *tile;
> @@ -665,8 +671,7 @@ static void xe_irq_reset(struct xe_device *xe)
>  			xelp_irq_reset(tile);
>  	}
>  
> -	tile = xe_device_get_root_tile(xe);
> -	mask_and_disable(tile, GU_MISC_IRQ_OFFSET);
> +	xe_gu_misc_irq_reset(xe);
>  	xe_display_irq_reset(xe);
>  	xe_i2c_irq_reset(xe);
>  
> @@ -696,6 +701,16 @@ static void vf_irq_postinstall(struct xe_device *xe)
>  		xe_assert(xe, xe_device_has_memirq(xe));
>  }
>  
> +static void xe_gu_misc_irq_postinstall(struct xe_device *xe)
> +{
> +	/*
> +	 * ASLE backlight operations are reported via GUnit GSE interrupts
> +	 * on the root tile.
> +	 */
> +	unmask_and_enable(xe_device_get_root_tile(xe),
> +			  GU_MISC_IRQ_OFFSET, GU_MISC_GSE);
> +}
> +
>  static void xe_irq_postinstall(struct xe_device *xe)
>  {
>  	if (IS_SRIOV_VF(xe))
> @@ -711,13 +726,7 @@ static void xe_irq_postinstall(struct xe_device *xe)
>  
>  	xe_display_irq_postinstall(xe);
>  	xe_i2c_irq_postinstall(xe);
> -
> -	/*
> -	 * ASLE backlight operations are reported via GUnit GSE interrupts
> -	 * on the root tile.
> -	 */
> -	unmask_and_enable(xe_device_get_root_tile(xe),
> -			  GU_MISC_IRQ_OFFSET, GU_MISC_GSE);
> +	xe_gu_misc_irq_postinstall(xe);
>  
>  	/* Enable top-level interrupts */
>  	if (GRAPHICS_VERx100(xe) >= 1210)

-- 
Jani Nikula, Intel