Re: [PATCH 1/4] drm/xe: s/xe_display_irq_enable()/xe_display_gse_irq_handler()/

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 09 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> xe_display_irq_enable() is actually the GSE interrupt *handler*,
> not some irq enable function. Rename it accordingly.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 2 +-
>  drivers/gpu/drm/xe/display/xe_display.h | 4 ++--
>  drivers/gpu/drm/xe/xe_irq.c             | 5 +++--
>  3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index aab416485e3e..f5538e450e3e 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -195,7 +195,7 @@ void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl)
>  		intel_display_irq_handler(display, NULL);
>  }
>  
> -void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir)
> +void xe_display_gse_irq_handler(struct xe_device *xe, u32 gu_misc_iir)
>  {
>  	struct intel_display *display = xe->display;
>  
> diff --git a/drivers/gpu/drm/xe/display/xe_display.h b/drivers/gpu/drm/xe/display/xe_display.h
> index 0babb50bfc77..370be8ec1044 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.h
> +++ b/drivers/gpu/drm/xe/display/xe_display.h
> @@ -33,7 +33,7 @@ void xe_display_shutdown(struct xe_device *xe);
>  void xe_display_shutdown_late(struct xe_device *xe);
>  
>  void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl);
> -void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir);
> +void xe_display_gse_irq_handler(struct xe_device *xe, u32 gu_misc_iir);
>  void xe_display_irq_reset(struct xe_device *xe);
>  void xe_display_irq_postinstall(struct xe_device *xe);
>  
> @@ -71,7 +71,7 @@ static inline void xe_display_shutdown(struct xe_device *xe) {}
>  static inline void xe_display_shutdown_late(struct xe_device *xe) {}
>  
>  static inline void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl) {}
> -static inline void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir) {}
> +static inline void xe_display_gse_irq_handler(struct xe_device *xe, u32 gu_misc_iir) {}
>  static inline void xe_display_irq_reset(struct xe_device *xe) {}
>  static inline void xe_display_irq_postinstall(struct xe_device *xe) {}
>  
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index b394c8edf89c..320fc64e7d4f 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -435,7 +435,7 @@ static irqreturn_t xelp_irq_handler(int irq, void *arg)
>  
>  	xelp_intr_enable(xe, false);
>  
> -	xe_display_irq_enable(xe, gu_misc_iir);
> +	xe_display_gse_irq_handler(xe, gu_misc_iir);
>  
>  	return IRQ_HANDLED;
>  }
> @@ -533,7 +533,8 @@ static irqreturn_t dg1_irq_handler(int irq, void *arg)
>  	}
>  
>  	dg1_intr_enable(xe, false);
> -	xe_display_irq_enable(xe, gu_misc_iir);
> +
> +	xe_display_gse_irq_handler(xe, gu_misc_iir);
>  
>  	return IRQ_HANDLED;
>  }

-- 
Jani Nikula, Intel