[PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack

[PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack

[Juasheem Sultan]

VSC SDP revision 7 (Panel Replay + Pixel Encoding/Colorimetry Format)
unpacking is missing in intel_dp_vsc_sdp_unpack(). This causes pipe
state mismatches during state readout because the VSC SDP state is not
properly recovered when Panel Replay is active with colorimetry.

Add the missing case for revision 7 to intel_dp_vsc_sdp_unpack()
so that the state is correctly recovered.

v2: Rebase onto latest upstream
v3: Fix git commit description

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Chaitanya Borah <chaitanya.kumar.borah@intel.com>
Cc: Gil Dekel <gildekel@google.com>
Signed-off-by: Juasheem Sultan <jdsultan@google.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 6ef2a0043cda..b8746dab051c 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5343,11 +5343,15 @@ static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
 		 *   VSC SDP supporting 3D stereo + Panel Replay.
 		 */
 		return 0;
-	} else if (sdp->sdp_header.HB2 == 0x5 && sdp->sdp_header.HB3 == 0x13) {
+	} else if ((sdp->sdp_header.HB2 == 0x5 || sdp->sdp_header.HB2 == 0x7) &&
+			sdp->sdp_header.HB3 == 0x13) {
 		/*
 		 * - HB2 = 0x5, HB3 = 0x13
 		 *   VSC SDP supporting 3D stereo + PSR2 + Pixel Encoding/Colorimetry
 		 *   Format.
+		 * - HB2 = 0x7, HB3 = 0x13
+		 *   VSC SDP supporting 3D stereo + Panel Replay + Pixel Encoding/Colorimetry
+		 *   Format.
 		 */
 		vsc->pixelformat = (sdp->db[16] >> 4) & 0xf;
 		vsc->colorimetry = sdp->db[16] & 0xf;
-- 
2.54.0.1013.g208068f2d8-goog

Re: [PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack

[Borah, Chaitanya Kumar]

On 6/3/2026 2:24 AM, Juasheem Sultan wrote:
> VSC SDP revision 7 (Panel Replay + Pixel Encoding/Colorimetry Format)
> unpacking is missing in intel_dp_vsc_sdp_unpack(). This causes pipe
> state mismatches during state readout because the VSC SDP state is not
> properly recovered when Panel Replay is active with colorimetry.
> 
> Add the missing case for revision 7 to intel_dp_vsc_sdp_unpack()
> so that the state is correctly recovered.
> 
> v2: Rebase onto latest upstream
> v3: Fix git commit description
> 

LGTM.
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Chaitanya Borah <chaitanya.kumar.borah@intel.com>
> Cc: Gil Dekel <gildekel@google.com>
> Signed-off-by: Juasheem Sultan <jdsultan@google.com>
> ---
>   drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 6ef2a0043cda..b8746dab051c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5343,11 +5343,15 @@ static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
>   		 *   VSC SDP supporting 3D stereo + Panel Replay.
>   		 */
>   		return 0;
> -	} else if (sdp->sdp_header.HB2 == 0x5 && sdp->sdp_header.HB3 == 0x13) {
> +	} else if ((sdp->sdp_header.HB2 == 0x5 || sdp->sdp_header.HB2 == 0x7) &&
> +			sdp->sdp_header.HB3 == 0x13) {
>   		/*
>   		 * - HB2 = 0x5, HB3 = 0x13
>   		 *   VSC SDP supporting 3D stereo + PSR2 + Pixel Encoding/Colorimetry
>   		 *   Format.
> +		 * - HB2 = 0x7, HB3 = 0x13
> +		 *   VSC SDP supporting 3D stereo + Panel Replay + Pixel Encoding/Colorimetry
> +		 *   Format.
>   		 */
>   		vsc->pixelformat = (sdp->db[16] >> 4) & 0xf;
>   		vsc->colorimetry = sdp->db[16] & 0xf;

Re: [PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack

[Nautiyal, Ankit K]

On 9/19/2026 1:07 AM, Gil Dekel wrote:
> Hi all,
> If I'm reading this correctly, it seems like this patch was LGTMd but 
> hasn't been merged yet.
> We would really like to pull this patch into our kernels as it is the 
> source of a lot of log spam around seamless modesets.
>
> Is there a reason this hasn't been merged yet?
> Thank you in advance.


Thanks for the patch and the reviews. Pushed to drm-intel-next.

Regards,

Ankit


>
> Sincerely,
>
> On Wed, Jun 3, 2026 at 7:40 AM Borah, Chaitanya Kumar 
> <chaitanya.kumar.borah@intel.com> wrote:
>
>     On 6/3/2026 2:24 AM, Juasheem Sultan wrote:
>     > VSC SDP revision 7 (Panel Replay + Pixel Encoding/Colorimetry
>     Format)
>     > unpacking is missing in intel_dp_vsc_sdp_unpack(). This causes pipe
>     > state mismatches during state readout because the VSC SDP state
>     is not
>     > properly recovered when Panel Replay is active with colorimetry.
>     >
>     > Add the missing case for revision 7 to intel_dp_vsc_sdp_unpack()
>     > so that the state is correctly recovered.
>     >
>     > v2: Rebase onto latest upstream
>     > v3: Fix git commit description
>     >
>
>     LGTM.
>     Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>
>     > Cc: Jani Nikula <jani.nikula@linux.intel.com>
>     > Cc: Chaitanya Borah <chaitanya.kumar.borah@intel.com>
>     > Cc: Gil Dekel <gildekel@google.com>
>     > Signed-off-by: Juasheem Sultan <jdsultan@google.com>
>     > ---
>     >   drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
>     >   1 file changed, 5 insertions(+), 1 deletion(-)
>     >
>     > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>     b/drivers/gpu/drm/i915/display/intel_dp.c
>     > index 6ef2a0043cda..b8746dab051c 100644
>     > --- a/drivers/gpu/drm/i915/display/intel_dp.c
>     > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>     > @@ -5343,11 +5343,15 @@ static int
>     intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
>     >                *   VSC SDP supporting 3D stereo + Panel Replay.
>     >                */
>     >               return 0;
>     > -     } else if (sdp->sdp_header.HB2 == 0x5 &&
>     sdp->sdp_header.HB3 == 0x13) {
>     > +     } else if ((sdp->sdp_header.HB2 == 0x5 ||
>     sdp->sdp_header.HB2 == 0x7) &&
>     > +                     sdp->sdp_header.HB3 == 0x13) {
>     >               /*
>     >                * - HB2 = 0x5, HB3 = 0x13
>     >                *   VSC SDP supporting 3D stereo + PSR2 + Pixel
>     Encoding/Colorimetry
>     >                *   Format.
>     > +              * - HB2 = 0x7, HB3 = 0x13
>     > +              *   VSC SDP supporting 3D stereo + Panel Replay +
>     Pixel Encoding/Colorimetry
>     > +              *   Format.
>     >                */
>     >               vsc->pixelformat = (sdp->db[16] >> 4) & 0xf;
>     >               vsc->colorimetry = sdp->db[16] & 0xf;
>
>
>
> -- 
>
>
> 	
> Gil Dekel
> *AluminiumOS*
> Desktop Experience
> Laptop & Tablets Display
>
> Software Engineer
> gildekel@google.com
> +1 (650) 861-2933
>

Re: [PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack

[Gil Dekel]

[-- Attachment #1: Type: text/plain, Size: 3606 bytes --]

Thank you kindly!

On Mon, Sep 21, 2026 at 9:03 AM Nautiyal, Ankit K <
ankit.k.nautiyal@intel.com> wrote:

>
> On 9/19/2026 1:07 AM, Gil Dekel wrote:
> > Hi all,
> > If I'm reading this correctly, it seems like this patch was LGTMd but
> > hasn't been merged yet.
> > We would really like to pull this patch into our kernels as it is the
> > source of a lot of log spam around seamless modesets.
> >
> > Is there a reason this hasn't been merged yet?
> > Thank you in advance.
>
>
> Thanks for the patch and the reviews. Pushed to drm-intel-next.
>
> Regards,
>
> Ankit
>
>
> >
> > Sincerely,
> >
> > On Wed, Jun 3, 2026 at 7:40 AM Borah, Chaitanya Kumar
> > <chaitanya.kumar.borah@intel.com> wrote:
> >
> >     On 6/3/2026 2:24 AM, Juasheem Sultan wrote:
> >     > VSC SDP revision 7 (Panel Replay + Pixel Encoding/Colorimetry
> >     Format)
> >     > unpacking is missing in intel_dp_vsc_sdp_unpack(). This causes pipe
> >     > state mismatches during state readout because the VSC SDP state
> >     is not
> >     > properly recovered when Panel Replay is active with colorimetry.
> >     >
> >     > Add the missing case for revision 7 to intel_dp_vsc_sdp_unpack()
> >     > so that the state is correctly recovered.
> >     >
> >     > v2: Rebase onto latest upstream
> >     > v3: Fix git commit description
> >     >
> >
> >     LGTM.
> >     Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> >
> >     > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> >     > Cc: Chaitanya Borah <chaitanya.kumar.borah@intel.com>
> >     > Cc: Gil Dekel <gildekel@google.com>
> >     > Signed-off-by: Juasheem Sultan <jdsultan@google.com>
> >     > ---
> >     >   drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
> >     >   1 file changed, 5 insertions(+), 1 deletion(-)
> >     >
> >     > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> >     b/drivers/gpu/drm/i915/display/intel_dp.c
> >     > index 6ef2a0043cda..b8746dab051c 100644
> >     > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> >     > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> >     > @@ -5343,11 +5343,15 @@ static int
> >     intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
> >     >                *   VSC SDP supporting 3D stereo + Panel Replay.
> >     >                */
> >     >               return 0;
> >     > -     } else if (sdp->sdp_header.HB2 == 0x5 &&
> >     sdp->sdp_header.HB3 == 0x13) {
> >     > +     } else if ((sdp->sdp_header.HB2 == 0x5 ||
> >     sdp->sdp_header.HB2 == 0x7) &&
> >     > +                     sdp->sdp_header.HB3 == 0x13) {
> >     >               /*
> >     >                * - HB2 = 0x5, HB3 = 0x13
> >     >                *   VSC SDP supporting 3D stereo + PSR2 + Pixel
> >     Encoding/Colorimetry
> >     >                *   Format.
> >     > +              * - HB2 = 0x7, HB3 = 0x13
> >     > +              *   VSC SDP supporting 3D stereo + Panel Replay +
> >     Pixel Encoding/Colorimetry
> >     > +              *   Format.
> >     >                */
> >     >               vsc->pixelformat = (sdp->db[16] >> 4) & 0xf;
> >     >               vsc->colorimetry = sdp->db[16] & 0xf;
> >
> >
> >
> > --
> >
> >
> >
> > Gil Dekel
> > *AluminiumOS*
> > Desktop Experience
> > Laptop & Tablets Display
> >
> > Software Engineer
> > gildekel@google.com
> > +1 (650) 861-2933 <(650)%20861-2933>
> >
>


-- 

Gil Dekel
*AluminiumOS*
Desktop Experience
Laptop & Tablets Display

Software Engineer
gildekel@google.com
+1 (650) 861-2933

[-- Attachment #2: Type: text/html, Size: 7668 bytes --]