Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [Intel-xe] [PATCH v11 08/12] drm/xe/mmio: enforce xe_device_assert_mem_access
Date: Mon, 12 Jun 2023 18:12:21 +0100	[thread overview]
Message-ID: <20230612171225.88689-9-matthew.auld@intel.com> (raw)
In-Reply-To: <20230612171225.88689-1-matthew.auld@intel.com>

The mem_access is meant to cover any kind of device level memory
access, mmio included.

Suggested-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/xe/xe_mmio.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_mmio.h b/drivers/gpu/drm/xe/xe_mmio.h
index 3c547d78afba..1a6f0fa9e04e 100644
--- a/drivers/gpu/drm/xe/xe_mmio.h
+++ b/drivers/gpu/drm/xe/xe_mmio.h
@@ -10,6 +10,7 @@
 #include <linux/io-64-nonatomic-lo-hi.h>
 
 #include "regs/xe_reg_defs.h"
+#include "xe_device.h"
 #include "xe_device_types.h"
 #include "xe_gt_types.h"
 
@@ -25,6 +26,8 @@ static inline u8 xe_mmio_read8(struct xe_gt *gt, struct xe_reg reg)
 {
 	struct xe_tile *tile = gt_to_tile(gt);
 
+	xe_device_assert_mem_access(tile->xe);
+
 	if (reg.addr < gt->mmio.adj_limit)
 		reg.addr += gt->mmio.adj_offset;
 
@@ -36,6 +39,8 @@ static inline void xe_mmio_write32(struct xe_gt *gt,
 {
 	struct xe_tile *tile = gt_to_tile(gt);
 
+	xe_device_assert_mem_access(tile->xe);
+
 	if (reg.addr < gt->mmio.adj_limit)
 		reg.addr += gt->mmio.adj_offset;
 
@@ -46,6 +51,8 @@ static inline u32 xe_mmio_read32(struct xe_gt *gt, struct xe_reg reg)
 {
 	struct xe_tile *tile = gt_to_tile(gt);
 
+	xe_device_assert_mem_access(tile->xe);
+
 	if (reg.addr < gt->mmio.adj_limit)
 		reg.addr += gt->mmio.adj_offset;
 
@@ -69,6 +76,8 @@ static inline void xe_mmio_write64(struct xe_gt *gt,
 {
 	struct xe_tile *tile = gt_to_tile(gt);
 
+	xe_device_assert_mem_access(tile->xe);
+
 	if (reg.addr < gt->mmio.adj_limit)
 		reg.addr += gt->mmio.adj_offset;
 
@@ -79,6 +88,8 @@ static inline u64 xe_mmio_read64(struct xe_gt *gt, struct xe_reg reg)
 {
 	struct xe_tile *tile = gt_to_tile(gt);
 
+	xe_device_assert_mem_access(tile->xe);
+
 	if (reg.addr < gt->mmio.adj_limit)
 		reg.addr += gt->mmio.adj_offset;
 
-- 
2.40.1


  parent reply	other threads:[~2023-06-12 17:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 17:12 [Intel-xe] [PATCH v11 00/12] xe_device_mem_access fixes and related bits Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 01/12] drm/xe: fix xe_device_mem_access_get() races Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 02/12] drm/xe/vm: tidy up xe_runtime_pm usage Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 03/12] drm/xe/debugfs: grab mem_access around forcewake Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 04/12] drm/xe/mmio: grab mem_access in xe_mmio_ioctl Matthew Auld
2023-06-12 18:13   ` Matthew Brost
2023-06-13  8:30     ` Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 05/12] drm/xe: ensure correct access_put ordering Matthew Auld
2023-06-12 18:16   ` Matthew Brost
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 06/12] drm/xe/pci: wrap probe with mem_access Matthew Auld
2023-06-12 18:34   ` Matthew Brost
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 07/12] drm/xe/display: use mem_access underneath Matthew Auld
2023-06-12 17:12 ` Matthew Auld [this message]
2023-06-12 18:17   ` [Intel-xe] [PATCH v11 08/12] drm/xe/mmio: enforce xe_device_assert_mem_access Matthew Brost
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 09/12] drm/xe: drop xe_device_mem_access_get() from guc_ct_send Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 10/12] drm/xe/ggtt: prime ggtt->lock against FS_RECLAIM Matthew Auld
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 11/12] drm/xe: drop xe_device_mem_access_get() from invalidation_vma Matthew Auld
2023-06-12 18:22   ` Matthew Brost
2023-06-12 17:12 ` [Intel-xe] [PATCH v11 12/12] drm/xe: add lockdep annotation for xe_device_mem_access_get() Matthew Auld
2023-06-12 18:32   ` Matthew Brost
2023-06-13  9:42   ` Thomas Hellström
2023-06-13 10:13     ` Matthew Auld
2023-06-12 17:16 ` [Intel-xe] ✓ CI.Patch_applied: success for xe_device_mem_access fixes and related bits Patchwork
2023-06-12 17:17 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-06-12 17:18 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-06-12 17:22 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-12 17:22 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-12 17:23 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-06-12 17:52 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612171225.88689-9-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox