Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: maarten.lankhorst@linux.intel.com
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 07/14] ALSA: hda/i915: Allow override of gpu binding.
Date: Mon,  2 Oct 2023 21:38:40 +0200	[thread overview]
Message-ID: <20231002193847.7134-7-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20231002193847.7134-1-maarten.lankhorst@linux.intel.com>

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Selecting CONFIG_DRM selects CONFIG_VIDEO_NOMODESET, which exports
video_firmware_drivers_only(). This can be used as a first
approximation on whether i915 will be available. It's safe to use as
this is only built when CONFIG_SND_HDA_I915 is selected by CONFIG_I915.

It's not completely fool proof, as you can boot with "nomodeset
i915.modeset=1" to make i915 load regardless, or use
"i915.force_probe=!*" to never load i915, but the common case of
booting with nomodeset to disable all GPU drivers this will work as
intended.

Because of this, we add an extra module parameter,
snd_hda_core.gpu_bind that can be used to signal users intent.
-1 follows nomodeset, 0 disables binding, 1 forces wait/-EPROBE_DEFER
on binding.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/hda/hdac_i915.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index ac10c4feb49c..961d99422bc5 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -10,6 +10,12 @@
 #include <sound/hdaudio.h>
 #include <sound/hda_i915.h>
 #include <sound/hda_register.h>
+#include <video/nomodeset.h>
+
+static int gpu_bind = -1;
+module_param(gpu_bind, int, 0644);
+MODULE_PARM_DESC(gpu_bind, "Whether to bind sound component to GPU "
+			   "(1=always, 0=never, -1=on nomodeset(default))");
 
 /**
  * snd_hdac_i915_set_bclk - Reprogram BCLK for HSW/BDW
@@ -122,6 +128,9 @@ static int i915_gfx_present(struct pci_dev *hdac_pci)
 {
 	struct pci_dev *display_dev = NULL;
 
+	if (!gpu_bind || (gpu_bind < 0 && video_firmware_drivers_only()))
+		return false;
+
 	for_each_pci_dev(display_dev) {
 		if (display_dev->vendor == PCI_VENDOR_ID_INTEL &&
 		    (display_dev->class >> 16) == PCI_BASE_CLASS_DISPLAY &&
-- 
2.40.1


  parent reply	other threads:[~2023-10-02 19:39 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 19:38 [Intel-xe] [PATCH 01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 02/14] Revert "sound/hda: Allow XE as i915 replacement for sound" maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 03/14] ASoC/SOF/core: Ensure sof_ops_free() is still called when probe never ran maarten.lankhorst
2023-10-03  7:58   ` Jani Nikula
2023-10-02 19:38 ` [Intel-xe] [PATCH 04/14] ASoC: SOF: core: Add probe_early and remove_late callbacks maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 05/14] ASoC: SOF: Intel: hda: start splitting the probe maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 06/14] ALSA: hda/intel: Fix error handling in azx_probe() maarten.lankhorst
2023-10-02 19:38 ` maarten.lankhorst [this message]
2023-10-02 19:38 ` [Intel-xe] [PATCH 08/14] ALSA: hda/i915: Add an allow_modprobe argument to snd_hdac_i915_init maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 09/14] ALSA: hda/i915: Allow xe as match for i915_component_master_match maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 10/14] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 11/14] ALSA: hda/intel: " maarten.lankhorst
2023-11-14 11:06   ` Ville Syrjälä
2023-11-14 12:35     ` Jani Nikula
2023-11-14 13:29       ` Maarten Lankhorst
2023-11-14 13:31         ` Saarinen, Jani
2023-11-14 16:52           ` Takashi Iwai
2023-11-14 17:24             ` Jani Nikula
2023-11-15  8:15             ` Kai Vehmanen
2023-11-14 13:39       ` Ville Syrjälä
2023-11-14 14:39         ` Maarten Lankhorst
2023-11-14 15:50           ` Takashi Iwai
2023-11-14 15:52             ` Maarten Lankhorst
2023-11-14 15:09     ` Takashi Iwai
2023-10-02 19:38 ` [Intel-xe] [PATCH 12/14] ASoC: Intel: Skylake: " maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 13/14] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 14/14] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init maarten.lankhorst
2023-10-02 20:28 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" Patchwork
2023-10-03 10:50 ` [Intel-xe] ✓ CI.Patch_applied: success " Patchwork
2023-10-03 10:50 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-03 10:51 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-03 10:58 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-03 10:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-03 11:00 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-10-03 11:37 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-11-14 16:30 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" (rev3) Patchwork
2023-11-15 23:27 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" (rev4) Patchwork
2023-11-17 21:33 ` Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-10-03 12:00 [Intel-xe] [PATCH 00/14] Update sound patches to upstreamable versions maarten.lankhorst
2023-10-03 12:00 ` [Intel-xe] [PATCH 07/14] ALSA: hda/i915: Allow override of gpu binding maarten.lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231002193847.7134-7-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox