From: Takashi Iwai <tiwai@suse.de>
To: "Saarinen, Jani" <jani.saarinen@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: Re: [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.
Date: Tue, 14 Nov 2023 17:52:40 +0100 [thread overview]
Message-ID: <87jzqkp99j.wl-tiwai@suse.de> (raw)
In-Reply-To: <DM8PR11MB5655518A6F21A2E4CA2E76D3E0B2A@DM8PR11MB5655.namprd11.prod.outlook.com>
On Tue, 14 Nov 2023 14:31:25 +0100,
Saarinen, Jani wrote:
>
> Hi,
> > -----Original Message-----
> > From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Sent: Tuesday, November 14, 2023 3:30 PM
> > To: Jani Nikula <jani.nikula@linux.intel.com>; Ville Syrjälä
> > <ville.syrjala@linux.intel.com>
> > Cc: Takashi Iwai <tiwai@suse.de>; intel-gfx@lists.freedesktop.org; intel-
> > xe@lists.freedesktop.org; alsa-devel@alsa-project.org; Saarinen, Jani
> > <jani.saarinen@intel.com>; Kurmi, Suresh Kumar
> > <suresh.kumar.kurmi@intel.com>
> > Subject: Re: [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init
> > to before probe_work.
> >
> > Hey,
> >
> > Den 2023-11-14 kl. 13:35, skrev Jani Nikula:
> > > On Tue, 14 Nov 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > >> On Mon, Oct 02, 2023 at 09:38:44PM +0200,
> > maarten.lankhorst@linux.intel.com wrote:
> > >>> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > >>>
> > >>> Now that we can use -EPROBE_DEFER, it's no longer required to spin
> > >>> off the snd_hdac_i915_init into a workqueue.
> > >>>
> > >>> Use the -EPROBE_DEFER mechanism instead, which must be returned in
> > >>> the probe function.
> > >> This completely broke i915 audio!
> > >>
> > >> I also can't see any trace of this stuff ever being posted to
> > >> intel-gfx so it never went through the CI.
> > >>
> > >> Please fix or revert ASAP.
> > > Cc: Jani, Suresh
> > >
> > > Ville, please file a bug at gitlab so we can track this, thanks.
> >
> > I've originally tested this on TGL and DG2, so can you be more specific on what
> > broke?
> Was this series tested on CI ever as Ville saying no? How this got merged?
Hm, I somehow believed that patches have been tested by intel people,
as they came from intel. (Also thought that drm-tip or whatever tree
also drags the recent changes from sound.git tree for relevant part.)
In anyway, the whole patches were touching only sound/* files and no
changes in DRM side at all, hence they weren't sent to intel-gfx, I
suppose.
Takashi
next prev parent reply other threads:[~2023-11-14 16:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 19:38 [Intel-xe] [PATCH 01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 02/14] Revert "sound/hda: Allow XE as i915 replacement for sound" maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 03/14] ASoC/SOF/core: Ensure sof_ops_free() is still called when probe never ran maarten.lankhorst
2023-10-03 7:58 ` Jani Nikula
2023-10-02 19:38 ` [Intel-xe] [PATCH 04/14] ASoC: SOF: core: Add probe_early and remove_late callbacks maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 05/14] ASoC: SOF: Intel: hda: start splitting the probe maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 06/14] ALSA: hda/intel: Fix error handling in azx_probe() maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 07/14] ALSA: hda/i915: Allow override of gpu binding maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 08/14] ALSA: hda/i915: Add an allow_modprobe argument to snd_hdac_i915_init maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 09/14] ALSA: hda/i915: Allow xe as match for i915_component_master_match maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 10/14] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 11/14] ALSA: hda/intel: " maarten.lankhorst
2023-11-14 11:06 ` Ville Syrjälä
2023-11-14 12:35 ` Jani Nikula
2023-11-14 13:29 ` Maarten Lankhorst
2023-11-14 13:31 ` Saarinen, Jani
2023-11-14 16:52 ` Takashi Iwai [this message]
2023-11-14 17:24 ` Jani Nikula
2023-11-15 8:15 ` Kai Vehmanen
2023-11-14 13:39 ` Ville Syrjälä
2023-11-14 14:39 ` Maarten Lankhorst
2023-11-14 15:50 ` Takashi Iwai
2023-11-14 15:52 ` Maarten Lankhorst
2023-11-14 15:09 ` Takashi Iwai
2023-10-02 19:38 ` [Intel-xe] [PATCH 12/14] ASoC: Intel: Skylake: " maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 13/14] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 14/14] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init maarten.lankhorst
2023-10-02 20:28 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" Patchwork
2023-10-03 10:50 ` [Intel-xe] ✓ CI.Patch_applied: success " Patchwork
2023-10-03 10:50 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-03 10:51 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-03 10:58 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-03 10:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-03 11:00 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-10-03 11:37 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-11-14 16:30 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" (rev3) Patchwork
2023-11-15 23:27 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" (rev4) Patchwork
2023-11-17 21:33 ` Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-10-03 12:00 [Intel-xe] [PATCH 00/14] Update sound patches to upstreamable versions maarten.lankhorst
2023-10-03 12:00 ` [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work maarten.lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzqkp99j.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox