From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>, <thomas.hellstrom@linux.intel.com>
Subject: [PATCH 03/16] drm/gpuvm: export drm_gpuvm_range_valid()
Date: Fri, 8 Dec 2023 01:46:30 -0500 [thread overview]
Message-ID: <20231208064643.877688-4-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20231208064643.877688-1-rodrigo.vivi@intel.com>
From: Danilo Krummrich <dakr@redhat.com>
Drivers may use this function to validate userspace requests in advance,
hence export it.
(cherry picked from commit 9297cfc9405bc6b60540b8b8aaf930b7e449e15a)
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231108001259.15123-4-dakr@redhat.com
---
drivers/gpu/drm/drm_gpuvm.c | 14 +++++++++++++-
include/drm/drm_gpuvm.h | 1 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index 1cbeb4169f9c..dd46d14fd3e6 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -649,7 +649,18 @@ drm_gpuvm_in_kernel_node(struct drm_gpuvm *gpuvm, u64 addr, u64 range)
return krange && addr < kend && kstart < end;
}
-static bool
+/**
+ * drm_gpuvm_range_valid() - checks whether the given range is valid for the
+ * given &drm_gpuvm
+ * @gpuvm: the GPUVM to check the range for
+ * @addr: the base address
+ * @range: the range starting from the base address
+ *
+ * Checks whether the range is within the GPUVM's managed boundaries.
+ *
+ * Returns: true for a valid range, false otherwise
+ */
+bool
drm_gpuvm_range_valid(struct drm_gpuvm *gpuvm,
u64 addr, u64 range)
{
@@ -657,6 +668,7 @@ drm_gpuvm_range_valid(struct drm_gpuvm *gpuvm,
drm_gpuvm_in_mm_range(gpuvm, addr, range) &&
!drm_gpuvm_in_kernel_node(gpuvm, addr, range);
}
+EXPORT_SYMBOL_GPL(drm_gpuvm_range_valid);
/**
* drm_gpuvm_init() - initialize a &drm_gpuvm
diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
index baa1a96c038c..ed766dd9d96b 100644
--- a/include/drm/drm_gpuvm.h
+++ b/include/drm/drm_gpuvm.h
@@ -253,6 +253,7 @@ void drm_gpuvm_init(struct drm_gpuvm *gpuvm, const char *name,
const struct drm_gpuvm_ops *ops);
void drm_gpuvm_destroy(struct drm_gpuvm *gpuvm);
+bool drm_gpuvm_range_valid(struct drm_gpuvm *gpuvm, u64 addr, u64 range);
bool drm_gpuvm_interval_empty(struct drm_gpuvm *gpuvm, u64 addr, u64 range);
static inline struct drm_gpuva *
--
2.43.0
next prev parent reply other threads:[~2023-12-08 6:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 6:46 [PATCH 00/16] Adjust to GPUVM / fixup version Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 01/16] drm/gpuvm: convert WARN() to drm_WARN() variants Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 02/16] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow() Rodrigo Vivi
2023-12-08 6:46 ` Rodrigo Vivi [this message]
2023-12-08 6:46 ` [PATCH 04/16] drm/nouveau: make use of drm_gpuvm_range_valid() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 05/16] drm/gpuvm: add common dma-resv per struct drm_gpuvm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 06/16] drm/nouveau: make use of the GPUVM's shared dma-resv Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 07/16] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 08/16] drm/nouveau: separately allocate struct nouveau_uvmm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 09/16] drm/gpuvm: reference count drm_gpuvm structures Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 10/16] drm/gpuvm: add an abstraction for a VM / BO combination Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 11/16] drm/gpuvm: track/lock/validate external/evicted objects Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 12/16] fixup! drm/xe/vm: Simplify and document xe_vm_lock() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 13/16] fixup! drm/xe: Convert pagefaulting code to use drm_exec Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 14/16] fixup! drm/xe: Rework xe_exec and the VM rebind worker to use the drm_exec helper Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 15/16] fixup! drm/xe: Convert remaining instances of ttm_eu_reserve_buffers to drm_exec Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 16/16] fixup! drm/xe: Port Xe to GPUVA Rodrigo Vivi
2023-12-08 10:34 ` ✓ CI.Patch_applied: success for Adjust to GPUVM / fixup version Patchwork
2023-12-08 10:35 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-08 10:36 ` ✓ CI.KUnit: success " Patchwork
2023-12-08 10:44 ` ✓ CI.Build: " Patchwork
2023-12-08 10:44 ` ✓ CI.Hooks: " Patchwork
2023-12-08 10:46 ` ✗ CI.checksparse: warning " Patchwork
2023-12-08 11:21 ` ✓ CI.BAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 14:11 [PATCH 00/16] drm/xe: Adjust to DRM GPUVM changes Thomas Hellström
2023-12-07 14:11 ` [PATCH 03/16] drm/gpuvm: export drm_gpuvm_range_valid() Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208064643.877688-4-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox