From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>, <thomas.hellstrom@linux.intel.com>
Subject: [PATCH 07/16] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm
Date: Fri, 8 Dec 2023 01:46:34 -0500 [thread overview]
Message-ID: <20231208064643.877688-8-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20231208064643.877688-1-rodrigo.vivi@intel.com>
From: Danilo Krummrich <dakr@redhat.com>
Introduce flags for struct drm_gpuvm, this required by subsequent
commits.
(cherry picked from commit 809ef191ee600e8bcbe2f8a769e00d2d54c16094)
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231108001259.15123-8-dakr@redhat.com
---
drivers/gpu/drm/drm_gpuvm.c | 3 +++
drivers/gpu/drm/nouveau/nouveau_uvmm.c | 2 +-
include/drm/drm_gpuvm.h | 16 ++++++++++++++++
3 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index 594ebcab5a4b..0a010b52e33d 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -720,6 +720,7 @@ EXPORT_SYMBOL_GPL(drm_gpuvm_resv_object_alloc);
* drm_gpuvm_init() - initialize a &drm_gpuvm
* @gpuvm: pointer to the &drm_gpuvm to initialize
* @name: the name of the GPU VA space
+ * @flags: the &drm_gpuvm_flags for this GPUVM
* @drm: the &drm_device this VM resides in
* @r_obj: the resv &drm_gem_object providing the GPUVM's common &dma_resv
* @start_offset: the start offset of the GPU VA space
@@ -735,6 +736,7 @@ EXPORT_SYMBOL_GPL(drm_gpuvm_resv_object_alloc);
*/
void
drm_gpuvm_init(struct drm_gpuvm *gpuvm, const char *name,
+ enum drm_gpuvm_flags flags,
struct drm_device *drm,
struct drm_gem_object *r_obj,
u64 start_offset, u64 range,
@@ -745,6 +747,7 @@ drm_gpuvm_init(struct drm_gpuvm *gpuvm, const char *name,
INIT_LIST_HEAD(&gpuvm->rb.list);
gpuvm->name = name ? name : "unknown";
+ gpuvm->flags = flags;
gpuvm->ops = ops;
gpuvm->drm = drm;
gpuvm->r_obj = r_obj;
diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
index 8977a518de96..f765e3835306 100644
--- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
@@ -1828,7 +1828,7 @@ nouveau_uvmm_init(struct nouveau_uvmm *uvmm, struct nouveau_cli *cli,
goto out_unlock;
}
- drm_gpuvm_init(&uvmm->base, cli->name, drm, r_obj,
+ drm_gpuvm_init(&uvmm->base, cli->name, 0, drm, r_obj,
NOUVEAU_VA_SPACE_START,
NOUVEAU_VA_SPACE_END,
kernel_managed_addr, kernel_managed_size,
diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
index 59b32c5b7d16..239680b83079 100644
--- a/include/drm/drm_gpuvm.h
+++ b/include/drm/drm_gpuvm.h
@@ -184,6 +184,16 @@ static inline bool drm_gpuva_invalidated(struct drm_gpuva *va)
return va->flags & DRM_GPUVA_INVALIDATED;
}
+/**
+ * enum drm_gpuvm_flags - flags for struct drm_gpuvm
+ */
+enum drm_gpuvm_flags {
+ /**
+ * @DRM_GPUVM_USERBITS: user defined bits
+ */
+ DRM_GPUVM_USERBITS = BIT(0),
+};
+
/**
* struct drm_gpuvm - DRM GPU VA Manager
*
@@ -202,6 +212,11 @@ struct drm_gpuvm {
*/
const char *name;
+ /**
+ * @flags: the &drm_gpuvm_flags of this GPUVM
+ */
+ enum drm_gpuvm_flags flags;
+
/**
* @drm: the &drm_device this VM lives in
*/
@@ -252,6 +267,7 @@ struct drm_gpuvm {
};
void drm_gpuvm_init(struct drm_gpuvm *gpuvm, const char *name,
+ enum drm_gpuvm_flags flags,
struct drm_device *drm,
struct drm_gem_object *r_obj,
u64 start_offset, u64 range,
--
2.43.0
next prev parent reply other threads:[~2023-12-08 6:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 6:46 [PATCH 00/16] Adjust to GPUVM / fixup version Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 01/16] drm/gpuvm: convert WARN() to drm_WARN() variants Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 02/16] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 03/16] drm/gpuvm: export drm_gpuvm_range_valid() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 04/16] drm/nouveau: make use of drm_gpuvm_range_valid() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 05/16] drm/gpuvm: add common dma-resv per struct drm_gpuvm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 06/16] drm/nouveau: make use of the GPUVM's shared dma-resv Rodrigo Vivi
2023-12-08 6:46 ` Rodrigo Vivi [this message]
2023-12-08 6:46 ` [PATCH 08/16] drm/nouveau: separately allocate struct nouveau_uvmm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 09/16] drm/gpuvm: reference count drm_gpuvm structures Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 10/16] drm/gpuvm: add an abstraction for a VM / BO combination Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 11/16] drm/gpuvm: track/lock/validate external/evicted objects Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 12/16] fixup! drm/xe/vm: Simplify and document xe_vm_lock() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 13/16] fixup! drm/xe: Convert pagefaulting code to use drm_exec Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 14/16] fixup! drm/xe: Rework xe_exec and the VM rebind worker to use the drm_exec helper Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 15/16] fixup! drm/xe: Convert remaining instances of ttm_eu_reserve_buffers to drm_exec Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 16/16] fixup! drm/xe: Port Xe to GPUVA Rodrigo Vivi
2023-12-08 10:34 ` ✓ CI.Patch_applied: success for Adjust to GPUVM / fixup version Patchwork
2023-12-08 10:35 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-08 10:36 ` ✓ CI.KUnit: success " Patchwork
2023-12-08 10:44 ` ✓ CI.Build: " Patchwork
2023-12-08 10:44 ` ✓ CI.Hooks: " Patchwork
2023-12-08 10:46 ` ✗ CI.checksparse: warning " Patchwork
2023-12-08 11:21 ` ✓ CI.BAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 14:11 [PATCH 00/16] drm/xe: Adjust to DRM GPUVM changes Thomas Hellström
2023-12-07 14:11 ` [PATCH 07/16] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208064643.877688-8-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox