From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>, <thomas.hellstrom@linux.intel.com>
Subject: [PATCH 04/16] drm/nouveau: make use of drm_gpuvm_range_valid()
Date: Fri, 8 Dec 2023 01:46:31 -0500 [thread overview]
Message-ID: <20231208064643.877688-5-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20231208064643.877688-1-rodrigo.vivi@intel.com>
From: Danilo Krummrich <dakr@redhat.com>
Use drm_gpuvm_range_valid() in order to validate userspace requests.
(cherry picked from commit b41e297abd2347075ec640daf0e5da576e3d7418)
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231108001259.15123-5-dakr@redhat.com
---
drivers/gpu/drm/nouveau/nouveau_uvmm.c | 17 +----------------
drivers/gpu/drm/nouveau/nouveau_uvmm.h | 3 ---
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
index aaf5d28bd587..641a911528db 100644
--- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
@@ -929,25 +929,13 @@ nouveau_uvmm_sm_unmap_cleanup(struct nouveau_uvmm *uvmm,
static int
nouveau_uvmm_validate_range(struct nouveau_uvmm *uvmm, u64 addr, u64 range)
{
- u64 end = addr + range;
- u64 kernel_managed_end = uvmm->kernel_managed_addr +
- uvmm->kernel_managed_size;
-
if (addr & ~PAGE_MASK)
return -EINVAL;
if (range & ~PAGE_MASK)
return -EINVAL;
- if (end <= addr)
- return -EINVAL;
-
- if (addr < NOUVEAU_VA_SPACE_START ||
- end > NOUVEAU_VA_SPACE_END)
- return -EINVAL;
-
- if (addr < kernel_managed_end &&
- end > uvmm->kernel_managed_addr)
+ if (!drm_gpuvm_range_valid(&uvmm->base, addr, range))
return -EINVAL;
return 0;
@@ -1834,9 +1822,6 @@ nouveau_uvmm_init(struct nouveau_uvmm *uvmm, struct nouveau_cli *cli,
goto out_unlock;
}
- uvmm->kernel_managed_addr = kernel_managed_addr;
- uvmm->kernel_managed_size = kernel_managed_size;
-
drm_gpuvm_init(&uvmm->base, cli->name, drm,
NOUVEAU_VA_SPACE_START,
NOUVEAU_VA_SPACE_END,
diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.h b/drivers/gpu/drm/nouveau/nouveau_uvmm.h
index a308c59760a5..06a0c36de392 100644
--- a/drivers/gpu/drm/nouveau/nouveau_uvmm.h
+++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.h
@@ -14,9 +14,6 @@ struct nouveau_uvmm {
struct mutex mutex;
struct dma_resv resv;
- u64 kernel_managed_addr;
- u64 kernel_managed_size;
-
bool disabled;
};
--
2.43.0
next prev parent reply other threads:[~2023-12-08 6:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 6:46 [PATCH 00/16] Adjust to GPUVM / fixup version Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 01/16] drm/gpuvm: convert WARN() to drm_WARN() variants Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 02/16] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 03/16] drm/gpuvm: export drm_gpuvm_range_valid() Rodrigo Vivi
2023-12-08 6:46 ` Rodrigo Vivi [this message]
2023-12-08 6:46 ` [PATCH 05/16] drm/gpuvm: add common dma-resv per struct drm_gpuvm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 06/16] drm/nouveau: make use of the GPUVM's shared dma-resv Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 07/16] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 08/16] drm/nouveau: separately allocate struct nouveau_uvmm Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 09/16] drm/gpuvm: reference count drm_gpuvm structures Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 10/16] drm/gpuvm: add an abstraction for a VM / BO combination Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 11/16] drm/gpuvm: track/lock/validate external/evicted objects Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 12/16] fixup! drm/xe/vm: Simplify and document xe_vm_lock() Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 13/16] fixup! drm/xe: Convert pagefaulting code to use drm_exec Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 14/16] fixup! drm/xe: Rework xe_exec and the VM rebind worker to use the drm_exec helper Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 15/16] fixup! drm/xe: Convert remaining instances of ttm_eu_reserve_buffers to drm_exec Rodrigo Vivi
2023-12-08 6:46 ` [PATCH 16/16] fixup! drm/xe: Port Xe to GPUVA Rodrigo Vivi
2023-12-08 10:34 ` ✓ CI.Patch_applied: success for Adjust to GPUVM / fixup version Patchwork
2023-12-08 10:35 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-08 10:36 ` ✓ CI.KUnit: success " Patchwork
2023-12-08 10:44 ` ✓ CI.Build: " Patchwork
2023-12-08 10:44 ` ✓ CI.Hooks: " Patchwork
2023-12-08 10:46 ` ✗ CI.checksparse: warning " Patchwork
2023-12-08 11:21 ` ✓ CI.BAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 14:11 [PATCH 00/16] drm/xe: Adjust to DRM GPUVM changes Thomas Hellström
2023-12-07 14:11 ` [PATCH 04/16] drm/nouveau: make use of drm_gpuvm_range_valid() Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208064643.877688-5-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox