Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v1 04/21] drm/xe/uapi: Remove DRM_XE_UFENCE_WAIT_MASK_*
Date: Fri, 15 Dec 2023 15:45:36 +0000	[thread overview]
Message-ID: <20231215154553.7-5-francois.dugast@intel.com> (raw)
In-Reply-To: <20231215154553.7-1-francois.dugast@intel.com>

Those are just possible values for the comparison mask but they are not
specific magic values. Let's keep them as examples in the documentation
but remove them from the uAPI.

Suggested-by: Matthew Brost <matthew.brost@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 include/uapi/drm/xe_drm.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 128369299e49..d122f985435a 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -1040,11 +1040,13 @@ struct drm_xe_wait_user_fence {
 	/** @value: compare value */
 	__u64 value;
 
-#define DRM_XE_UFENCE_WAIT_MASK_U8	0xffu
-#define DRM_XE_UFENCE_WAIT_MASK_U16	0xffffu
-#define DRM_XE_UFENCE_WAIT_MASK_U32	0xffffffffu
-#define DRM_XE_UFENCE_WAIT_MASK_U64	0xffffffffffffffffu
-	/** @mask: comparison mask */
+	/**
+	 * @mask: comparison mask, values can be for example:
+	 *  - 0xffu for u8
+	 *  - 0xffffu for u16
+	 *  - 0xffffffffu for u32
+	 *  - 0xffffffffffffffffu for u64
+	 */
 	__u64 mask;
 
 	/**
-- 
2.34.1


  parent reply	other threads:[~2023-12-15 15:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 15:45 [PATCH v1 00/21] uAPI Alignment - More cleanup before upstream Francois Dugast
2023-12-15 15:45 ` [PATCH v1 01/21] drm/xe/uapi: add exec_queue_id member to drm_xe_wait_user_fence structure Francois Dugast
2023-12-15 15:45 ` [PATCH v1 02/21] drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl Francois Dugast
2023-12-15 15:45 ` [PATCH v1 03/21] drm/xe/uapi: Remove DRM_IOCTL_XE_EXEC_QUEUE_SET_PROPERTY Francois Dugast
2023-12-15 15:45 ` Francois Dugast [this message]
2023-12-15 15:45 ` [PATCH v1 05/21] drm/xe/pmu: Remove PMU from Xe till uapi is finalized Francois Dugast
2023-12-15 15:45 ` [PATCH v1 06/21] drm/xe/uapi: Ensure every uapi struct has drm_xe prefix Francois Dugast
2023-12-15 15:45 ` [PATCH v1 07/21] drm/xe/uapi: Remove sync binds Francois Dugast
2023-12-15 15:45 ` [PATCH v1 08/21] drm/xe/uapi: Add a comment to each struct Francois Dugast
2023-12-15 15:45 ` [PATCH v1 09/21] drm/xe/uapi: Add missing documentation for struct members Francois Dugast
2023-12-15 15:45 ` [PATCH v1 10/21] drm/xe/uapi: Document use of size in drm_xe_device_query Francois Dugast
2023-12-15 15:45 ` [PATCH v1 11/21] drm/xe/uapi: Document drm_xe_query_config keys Francois Dugast
2023-12-15 15:45 ` [PATCH v1 12/21] drm/xe/uapi: Document DRM_XE_DEVICE_QUERY_HWCONFIG Francois Dugast
2023-12-15 15:45 ` [PATCH v1 13/21] drm/xe/uapi: Make constant comments visible in kernel doc Francois Dugast
2023-12-15 15:45 ` [PATCH v1 14/21] drm/xe/uapi: Order sections Francois Dugast
2023-12-15 15:45 ` [PATCH v1 15/21] drm/xe/uapi: More uAPI documentation additions and cosmetic updates Francois Dugast
2023-12-15 15:45 ` [PATCH v1 16/21] drm/xe/uapi: Document the memory_region bitmask Francois Dugast
2023-12-15 15:45 ` [PATCH v1 17/21] drm/xe/uapi: Add block diagram of a device Francois Dugast
2023-12-15 15:45 ` [PATCH v1 18/21] drm/xe/uapi: Add examples of user space code Francois Dugast
2023-12-15 15:45 ` [PATCH v1 19/21] drm/xe/uapi: Move CPU_CACHING defines before doc Francois Dugast
2023-12-15 15:45 ` [PATCH v1 20/21] drm/xe/uapi: Move DRM_XE_ACC_GRANULARITY_* where they are used Francois Dugast
2023-12-15 15:45 ` [PATCH v1 21/21] drm/xe/uapi: Remove reset uevent for now Francois Dugast
2023-12-15 16:35   ` Lucas De Marchi
2023-12-15 17:01 ` ✓ CI.Patch_applied: success for uAPI Alignment - More cleanup before upstream Patchwork
2023-12-15 17:02 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-15 17:03 ` ✓ CI.KUnit: success " Patchwork
2023-12-15 17:03 ` [PATCH v1 00/21] " Souza, Jose
2023-12-15 17:13 ` ✓ CI.Build: success for " Patchwork
2023-12-15 17:14 ` ✓ CI.Hooks: " Patchwork
2023-12-15 17:15 ` ✓ CI.checksparse: " Patchwork
2023-12-15 17:51 ` ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231215154553.7-5-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox