Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v1 06/21] drm/xe/uapi: Ensure every uapi struct has drm_xe prefix
Date: Fri, 15 Dec 2023 15:45:38 +0000	[thread overview]
Message-ID: <20231215154553.7-7-francois.dugast@intel.com> (raw)
In-Reply-To: <20231215154553.7-1-francois.dugast@intel.com>

From: Rodrigo Vivi <rodrigo.vivi@intel.com>

To ensure consistency and avoid possible later conflicts,
let's add drm_xe prefix to xe_user_extension struct.

Cc: Francois Dugast <francois.dugast@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_exec_queue.c |  2 +-
 include/uapi/drm/xe_drm.h          | 18 +++++++++---------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index eeb9605dd45f..aa478c66edbb 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -453,7 +453,7 @@ static int exec_queue_user_extensions(struct xe_device *xe, struct xe_exec_queue
 				      u64 extensions, int ext_number, bool create)
 {
 	u64 __user *address = u64_to_user_ptr(extensions);
-	struct xe_user_extension ext;
+	struct drm_xe_user_extension ext;
 	int err;
 	u32 idx;
 
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index e1e8fb1846ea..87ff6eaa788e 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -27,7 +27,7 @@ extern "C" {
 #define DRM_XE_RESET_FAILED_UEVENT "DEVICE_STATUS"
 
 /**
- * struct xe_user_extension - Base class for defining a chain of extensions
+ * struct drm_xe_user_extension - Base class for defining a chain of extensions
  *
  * Many interfaces need to grow over time. In most cases we can simply
  * extend the struct and have userspace pass in more data. Another option,
@@ -45,29 +45,29 @@ extern "C" {
  *
  * .. code-block:: C
  *
- *	struct xe_user_extension ext3 {
+ *	struct drm_xe_user_extension ext3 {
  *		.next_extension = 0, // end
  *		.name = ...,
  *	};
- *	struct xe_user_extension ext2 {
+ *	struct drm_xe_user_extension ext2 {
  *		.next_extension = (uintptr_t)&ext3,
  *		.name = ...,
  *	};
- *	struct xe_user_extension ext1 {
+ *	struct drm_xe_user_extension ext1 {
  *		.next_extension = (uintptr_t)&ext2,
  *		.name = ...,
  *	};
  *
- * Typically the struct xe_user_extension would be embedded in some uAPI
+ * Typically the struct drm_xe_user_extension would be embedded in some uAPI
  * struct, and in this case we would feed it the head of the chain(i.e ext1),
  * which would then apply all of the above extensions.
  *
  */
-struct xe_user_extension {
+struct drm_xe_user_extension {
 	/**
 	 * @next_extension:
 	 *
-	 * Pointer to the next struct xe_user_extension, or zero if the end.
+	 * Pointer to the next struct drm_xe_user_extension, or zero if the end.
 	 */
 	__u64 next_extension;
 
@@ -78,7 +78,7 @@ struct xe_user_extension {
 	 *
 	 * Also note that the name space for this is not global for the whole
 	 * driver, but rather its scope/meaning is limited to the specific piece
-	 * of uAPI which has embedded the struct xe_user_extension.
+	 * of uAPI which has embedded the struct drm_xe_user_extension.
 	 */
 	__u32 name;
 
@@ -625,7 +625,7 @@ struct drm_xe_gem_mmap_offset {
 /** struct drm_xe_ext_set_property - XE set property extension */
 struct drm_xe_ext_set_property {
 	/** @base: base user extension */
-	struct xe_user_extension base;
+	struct drm_xe_user_extension base;
 
 	/** @property: property to set */
 	__u32 property;
-- 
2.34.1


  parent reply	other threads:[~2023-12-15 15:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 15:45 [PATCH v1 00/21] uAPI Alignment - More cleanup before upstream Francois Dugast
2023-12-15 15:45 ` [PATCH v1 01/21] drm/xe/uapi: add exec_queue_id member to drm_xe_wait_user_fence structure Francois Dugast
2023-12-15 15:45 ` [PATCH v1 02/21] drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl Francois Dugast
2023-12-15 15:45 ` [PATCH v1 03/21] drm/xe/uapi: Remove DRM_IOCTL_XE_EXEC_QUEUE_SET_PROPERTY Francois Dugast
2023-12-15 15:45 ` [PATCH v1 04/21] drm/xe/uapi: Remove DRM_XE_UFENCE_WAIT_MASK_* Francois Dugast
2023-12-15 15:45 ` [PATCH v1 05/21] drm/xe/pmu: Remove PMU from Xe till uapi is finalized Francois Dugast
2023-12-15 15:45 ` Francois Dugast [this message]
2023-12-15 15:45 ` [PATCH v1 07/21] drm/xe/uapi: Remove sync binds Francois Dugast
2023-12-15 15:45 ` [PATCH v1 08/21] drm/xe/uapi: Add a comment to each struct Francois Dugast
2023-12-15 15:45 ` [PATCH v1 09/21] drm/xe/uapi: Add missing documentation for struct members Francois Dugast
2023-12-15 15:45 ` [PATCH v1 10/21] drm/xe/uapi: Document use of size in drm_xe_device_query Francois Dugast
2023-12-15 15:45 ` [PATCH v1 11/21] drm/xe/uapi: Document drm_xe_query_config keys Francois Dugast
2023-12-15 15:45 ` [PATCH v1 12/21] drm/xe/uapi: Document DRM_XE_DEVICE_QUERY_HWCONFIG Francois Dugast
2023-12-15 15:45 ` [PATCH v1 13/21] drm/xe/uapi: Make constant comments visible in kernel doc Francois Dugast
2023-12-15 15:45 ` [PATCH v1 14/21] drm/xe/uapi: Order sections Francois Dugast
2023-12-15 15:45 ` [PATCH v1 15/21] drm/xe/uapi: More uAPI documentation additions and cosmetic updates Francois Dugast
2023-12-15 15:45 ` [PATCH v1 16/21] drm/xe/uapi: Document the memory_region bitmask Francois Dugast
2023-12-15 15:45 ` [PATCH v1 17/21] drm/xe/uapi: Add block diagram of a device Francois Dugast
2023-12-15 15:45 ` [PATCH v1 18/21] drm/xe/uapi: Add examples of user space code Francois Dugast
2023-12-15 15:45 ` [PATCH v1 19/21] drm/xe/uapi: Move CPU_CACHING defines before doc Francois Dugast
2023-12-15 15:45 ` [PATCH v1 20/21] drm/xe/uapi: Move DRM_XE_ACC_GRANULARITY_* where they are used Francois Dugast
2023-12-15 15:45 ` [PATCH v1 21/21] drm/xe/uapi: Remove reset uevent for now Francois Dugast
2023-12-15 16:35   ` Lucas De Marchi
2023-12-15 17:01 ` ✓ CI.Patch_applied: success for uAPI Alignment - More cleanup before upstream Patchwork
2023-12-15 17:02 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-15 17:03 ` ✓ CI.KUnit: success " Patchwork
2023-12-15 17:03 ` [PATCH v1 00/21] " Souza, Jose
2023-12-15 17:13 ` ✓ CI.Build: success for " Patchwork
2023-12-15 17:14 ` ✓ CI.Hooks: " Patchwork
2023-12-15 17:15 ` ✓ CI.checksparse: " Patchwork
2023-12-15 17:51 ` ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231215154553.7-7-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox