Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v1 08/21] drm/xe/uapi: Add a comment to each struct
Date: Fri, 15 Dec 2023 15:45:40 +0000	[thread overview]
Message-ID: <20231215154553.7-9-francois.dugast@intel.com> (raw)
In-Reply-To: <20231215154553.7-1-francois.dugast@intel.com>

Add a comment to each struct to complete documentation, ensure all
struct appear in the kernel doc, and bind structs to IOCTLs.

Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 include/uapi/drm/xe_drm.h | 43 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)

diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 2338d87dcb7d..43cacb168091 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -464,7 +464,8 @@ struct drm_xe_query_topology_mask {
 };
 
 /**
- * struct drm_xe_device_query - main structure to query device information
+ * struct drm_xe_device_query - Input of &DRM_IOCTL_XE_DEVICE_QUERY - main
+ * structure to query device information
  *
  * If size is set to 0, the driver fills it with the required size for the
  * requested type of data to query. If size is equal to the required size,
@@ -526,6 +527,10 @@ struct drm_xe_device_query {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_gem_create - Input of &DRM_IOCTL_XE_GEM_CREATE - A structure for
+ * gem creation
+ */
 struct drm_xe_gem_create {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -604,6 +609,9 @@ struct drm_xe_gem_create {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_gem_mmap_offset - Input of &DRM_IOCTL_XE_GEM_MMAP_OFFSET
+ */
 struct drm_xe_gem_mmap_offset {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -621,7 +629,9 @@ struct drm_xe_gem_mmap_offset {
 	__u64 reserved[2];
 };
 
-/** struct drm_xe_ext_set_property - XE set property extension */
+/**
+ * struct drm_xe_ext_set_property - XE set property extension
+ */
 struct drm_xe_ext_set_property {
 	/** @base: base user extension */
 	struct drm_xe_user_extension base;
@@ -639,6 +649,9 @@ struct drm_xe_ext_set_property {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_vm_create - Input of &DRM_IOCTL_XE_VM_CREATE
+ */
 struct drm_xe_vm_create {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -677,6 +690,9 @@ struct drm_xe_vm_create {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_vm_destroy - Input of &DRM_IOCTL_XE_VM_DESTROY
+ */
 struct drm_xe_vm_destroy {
 	/** @vm_id: VM ID */
 	__u32 vm_id;
@@ -688,6 +704,9 @@ struct drm_xe_vm_destroy {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_vm_bind_op
+ */
 struct drm_xe_vm_bind_op {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -804,6 +823,9 @@ struct drm_xe_vm_bind_op {
 	__u64 reserved[3];
 };
 
+/**
+ * struct drm_xe_vm_bind - Input of &DRM_IOCTL_XE_VM_BIND
+ */
 struct drm_xe_vm_bind {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -862,6 +884,9 @@ struct drm_xe_vm_bind {
 /* Monitor 64MB contiguous region with 2M sub-granularity */
 #define DRM_XE_ACC_GRANULARITY_64M 3
 
+/**
+ * struct drm_xe_exec_queue_create - Input of &DRM_IOCTL_XE_EXEC_QUEUE_CREATE
+ */
 struct drm_xe_exec_queue_create {
 #define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY		0
 #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
@@ -904,6 +929,9 @@ struct drm_xe_exec_queue_create {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_exec_queue_get_property - Input of &DRM_IOCTL_XE_EXEC_QUEUE_GET_PROPERTY
+ */
 struct drm_xe_exec_queue_get_property {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -922,6 +950,9 @@ struct drm_xe_exec_queue_get_property {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_exec_queue_destroy - Input of &DRM_IOCTL_XE_EXEC_QUEUE_DESTROY
+ */
 struct drm_xe_exec_queue_destroy {
 	/** @exec_queue_id: Exec queue ID */
 	__u32 exec_queue_id;
@@ -933,6 +964,9 @@ struct drm_xe_exec_queue_destroy {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_sync
+ */
 struct drm_xe_sync {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -967,6 +1001,9 @@ struct drm_xe_sync {
 	__u64 reserved[2];
 };
 
+/**
+ * struct drm_xe_exec - Input of &DRM_IOCTL_XE_EXEC
+ */
 struct drm_xe_exec {
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;
@@ -1000,7 +1037,7 @@ struct drm_xe_exec {
 };
 
 /**
- * struct drm_xe_wait_user_fence - wait user fence
+ * struct drm_xe_wait_user_fence - Input of &DRM_IOCTL_XE_WAIT_USER_FENCE
  *
  * Wait on user fence, XE will wake-up on every HW engine interrupt in the
  * instances list and check if user fence is complete::
-- 
2.34.1


  parent reply	other threads:[~2023-12-15 15:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 15:45 [PATCH v1 00/21] uAPI Alignment - More cleanup before upstream Francois Dugast
2023-12-15 15:45 ` [PATCH v1 01/21] drm/xe/uapi: add exec_queue_id member to drm_xe_wait_user_fence structure Francois Dugast
2023-12-15 15:45 ` [PATCH v1 02/21] drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl Francois Dugast
2023-12-15 15:45 ` [PATCH v1 03/21] drm/xe/uapi: Remove DRM_IOCTL_XE_EXEC_QUEUE_SET_PROPERTY Francois Dugast
2023-12-15 15:45 ` [PATCH v1 04/21] drm/xe/uapi: Remove DRM_XE_UFENCE_WAIT_MASK_* Francois Dugast
2023-12-15 15:45 ` [PATCH v1 05/21] drm/xe/pmu: Remove PMU from Xe till uapi is finalized Francois Dugast
2023-12-15 15:45 ` [PATCH v1 06/21] drm/xe/uapi: Ensure every uapi struct has drm_xe prefix Francois Dugast
2023-12-15 15:45 ` [PATCH v1 07/21] drm/xe/uapi: Remove sync binds Francois Dugast
2023-12-15 15:45 ` Francois Dugast [this message]
2023-12-15 15:45 ` [PATCH v1 09/21] drm/xe/uapi: Add missing documentation for struct members Francois Dugast
2023-12-15 15:45 ` [PATCH v1 10/21] drm/xe/uapi: Document use of size in drm_xe_device_query Francois Dugast
2023-12-15 15:45 ` [PATCH v1 11/21] drm/xe/uapi: Document drm_xe_query_config keys Francois Dugast
2023-12-15 15:45 ` [PATCH v1 12/21] drm/xe/uapi: Document DRM_XE_DEVICE_QUERY_HWCONFIG Francois Dugast
2023-12-15 15:45 ` [PATCH v1 13/21] drm/xe/uapi: Make constant comments visible in kernel doc Francois Dugast
2023-12-15 15:45 ` [PATCH v1 14/21] drm/xe/uapi: Order sections Francois Dugast
2023-12-15 15:45 ` [PATCH v1 15/21] drm/xe/uapi: More uAPI documentation additions and cosmetic updates Francois Dugast
2023-12-15 15:45 ` [PATCH v1 16/21] drm/xe/uapi: Document the memory_region bitmask Francois Dugast
2023-12-15 15:45 ` [PATCH v1 17/21] drm/xe/uapi: Add block diagram of a device Francois Dugast
2023-12-15 15:45 ` [PATCH v1 18/21] drm/xe/uapi: Add examples of user space code Francois Dugast
2023-12-15 15:45 ` [PATCH v1 19/21] drm/xe/uapi: Move CPU_CACHING defines before doc Francois Dugast
2023-12-15 15:45 ` [PATCH v1 20/21] drm/xe/uapi: Move DRM_XE_ACC_GRANULARITY_* where they are used Francois Dugast
2023-12-15 15:45 ` [PATCH v1 21/21] drm/xe/uapi: Remove reset uevent for now Francois Dugast
2023-12-15 16:35   ` Lucas De Marchi
2023-12-15 17:01 ` ✓ CI.Patch_applied: success for uAPI Alignment - More cleanup before upstream Patchwork
2023-12-15 17:02 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-15 17:03 ` ✓ CI.KUnit: success " Patchwork
2023-12-15 17:03 ` [PATCH v1 00/21] " Souza, Jose
2023-12-15 17:13 ` ✓ CI.Build: success for " Patchwork
2023-12-15 17:14 ` ✓ CI.Hooks: " Patchwork
2023-12-15 17:15 ` ✓ CI.checksparse: " Patchwork
2023-12-15 17:51 ` ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231215154553.7-9-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox