From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/xe/display: fix i915_gem_object_is_shmem() wrapper
Date: Mon, 5 Feb 2024 15:31:11 +0000 [thread overview]
Message-ID: <20240205153110.38340-2-matthew.auld@intel.com> (raw)
shmem ensures the memory is cleared on allocation, however here we are
using TTM, which doesn't natively support shmem (other than for swap),
but instead just allocates normal system memory. And we only zero such
memory for userspace allocations. In the case of intel_fbdev we are
missing the memset_io().
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
index 68d9f6116bdf..777c20ceabab 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
@@ -10,7 +10,7 @@
#include "xe_bo.h"
-#define i915_gem_object_is_shmem(obj) ((obj)->flags & XE_BO_CREATE_SYSTEM_BIT)
+#define i915_gem_object_is_shmem(obj) (0) /* We don't use shmem */
static inline dma_addr_t i915_gem_object_get_dma_address(const struct xe_bo *bo, pgoff_t n)
{
--
2.43.0
next reply other threads:[~2024-02-05 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 15:31 Matthew Auld [this message]
2024-02-05 16:02 ` ✓ CI.Patch_applied: success for drm/xe/display: fix i915_gem_object_is_shmem() wrapper Patchwork
2024-02-05 16:02 ` ✓ CI.checkpatch: " Patchwork
2024-02-05 16:03 ` ✓ CI.KUnit: " Patchwork
2024-02-05 16:10 ` ✓ CI.Build: " Patchwork
2024-02-05 16:11 ` ✓ CI.Hooks: " Patchwork
2024-02-05 16:12 ` ✓ CI.checksparse: " Patchwork
2024-02-05 16:37 ` ✓ CI.BAT: " Patchwork
2024-02-09 8:39 ` [PATCH] " Kandpal, Suraj
2024-02-09 9:54 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205153110.38340-2-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox