Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/display: fix i915_gem_object_is_shmem() wrapper
@ 2024-02-05 15:31 Matthew Auld
  2024-02-05 16:02 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Matthew Auld @ 2024-02-05 15:31 UTC (permalink / raw)
  To: intel-xe

shmem ensures the memory is cleared on allocation, however here we are
using TTM, which doesn't natively support shmem (other than for swap),
but instead just allocates normal system memory. And we only zero such
memory for userspace allocations. In the case of intel_fbdev we are
missing the memset_io().

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
index 68d9f6116bdf..777c20ceabab 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
@@ -10,7 +10,7 @@
 
 #include "xe_bo.h"
 
-#define i915_gem_object_is_shmem(obj) ((obj)->flags & XE_BO_CREATE_SYSTEM_BIT)
+#define i915_gem_object_is_shmem(obj) (0) /* We don't use shmem */
 
 static inline dma_addr_t i915_gem_object_get_dma_address(const struct xe_bo *bo, pgoff_t n)
 {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-02-09  9:54 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-05 15:31 [PATCH] drm/xe/display: fix i915_gem_object_is_shmem() wrapper Matthew Auld
2024-02-05 16:02 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-05 16:02 ` ✓ CI.checkpatch: " Patchwork
2024-02-05 16:03 ` ✓ CI.KUnit: " Patchwork
2024-02-05 16:10 ` ✓ CI.Build: " Patchwork
2024-02-05 16:11 ` ✓ CI.Hooks: " Patchwork
2024-02-05 16:12 ` ✓ CI.checksparse: " Patchwork
2024-02-05 16:37 ` ✓ CI.BAT: " Patchwork
2024-02-09  8:39 ` [PATCH] " Kandpal, Suraj
2024-02-09  9:54   ` Matthew Auld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox