Re: [PATCH 1/4] drm/xe/vf: Support only GuC/HuC firmwares

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on wto [2024-cze-04 23:22:28 +0200]:
> Only GuC/HuC firmwares can be used by the VFs, don't claim support
> for any other firmware (like GSC) even if the driver can support it.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_uc_fw.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index 12346645a8e5..a69c61f6b064 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -657,6 +657,10 @@ static int uc_fw_request(struct xe_uc_fw *uc_fw, const struct firmware **firmwar
>  	uc_fw_auto_select(xe, uc_fw);
>  
>  	if (IS_SRIOV_VF(xe)) {
> +		/* Only GuC/HuC are supported */
> +		if (uc_fw->type != XE_UC_FW_TYPE_GUC &&
> +		    uc_fw->type != XE_UC_FW_TYPE_HUC)
> +			uc_fw->path = NULL;
>  		/* VF will support only firmwares that driver can autoselect */
>  		xe_uc_fw_change_status(uc_fw, uc_fw->path ?
>  				       XE_UC_FIRMWARE_PRELOADED :


LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.43.0
> 

--