Re: [PATCH 3/4] drm/xe/vf: Custom GuC reset

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on wto [2024-cze-04 23:22:30 +0200]:
> The VF drivers can't trigger real GuC firmware reset using GDRST
> register, but for the VF drivers it is sufficient to send VF_RESET
> message to reset any VF specific state maintained by the GuC.
> Use our existing VF bootstrap function as VF_RESET is part of it.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 086a048876ba..0bf6e01b8910 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -430,6 +430,9 @@ int xe_guc_reset(struct xe_guc *guc)
>  
>  	xe_force_wake_assert_held(gt_to_fw(gt), XE_FW_GT);
>  
> +	if (IS_SRIOV_VF(gt_to_xe(gt)))
> +		return xe_gt_sriov_vf_bootstrap(gt);
> +
>  	xe_mmio_write32(gt, GDRST, GRDOM_GUC);
>  
>  	ret = xe_mmio_wait32(gt, GDRST, GRDOM_GUC, 0, 5000, &gdrst, false);


LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.43.0
> 

--