Re: [PATCH 4/4] drm/xe/vf: Custom GT restart

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on wto [2024-cze-04 23:22:31 +0200]:
> Only few steps from the GT restart phase are applicable for the
> VF drivers, as initialization of PAT, WOPCM, MOCS or CCS mode can
> be done only by the native or PF drivers. Use custom GT restart
> function if running in VF mode.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 4e11662b78bd..57d84751e160 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -611,12 +611,34 @@ static int do_gt_reset(struct xe_gt *gt)
>  	return err;
>  }
>  
> +static int vf_gt_restart(struct xe_gt *gt)
> +{
> +	int err;
> +
> +	err = xe_uc_sanitize_reset(&gt->uc);
> +	if (err)
> +		return err;
> +
> +	err = xe_uc_init_hw(&gt->uc);
> +	if (err)
> +		return err;
> +
> +	err = xe_uc_start(&gt->uc);
> +	if (err)
> +		return err;
> +
> +	return 0;
> +}
> +
>  static int do_gt_restart(struct xe_gt *gt)
>  {
>  	struct xe_hw_engine *hwe;
>  	enum xe_hw_engine_id id;
>  	int err;
>  
> +	if (IS_SRIOV_VF(gt_to_xe(gt)))
> +		return vf_gt_restart(gt);
> +

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

>  	xe_pat_init(gt);
>  
>  	xe_gt_mcr_set_implicit_defaults(gt);
> -- 
> 2.43.0
> 

--