Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v3 0/6] Only timeout jobs if they run longer than timeout period
Date: Fri,  7 Jun 2024 17:20:57 -0700	[thread overview]
Message-ID: <20240608002103.2371696-1-matthew.brost@intel.com> (raw)

Debugging [1] hit a known flaw in the job timeout mechanism - jobs
timeout after a period of time in which they have been submitted to the
GuC not how long they have actually been running on the hardware.
Attempt to fix this.

Algorithm is as follows:
- Copy ctx timestamp from LRC to saved location at beginning of every
  job
- On TDR kick jobs off hardware via schedule disable so ctx timestamp is
  updated
- Compare ctx timestamp to saved ctx timestamp, if jobs having been
  running less than timeout period re-enable scheduling are restart TDR

New job cancel IGT [2] for testing.

v2:
- Promote to non-RFC as issues which I view as blockers have been resolved
- Address Jani and Michal v1 feedback
- Add GT clock timer calculation
v3:
- More testing
- Fix TDR state machine bugs exposed in testing
- Rebase for CI

Matt

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/799
[2] https://patchwork.freedesktop.org/series/134640/

Matthew Brost (6):
  drm/xe: Add LRC ctx timestamp support functions
  drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions
  drm/xe: Emit ctx timestamp copy in ring ops
  drm/xe: Add ctx timestamp to LRC snapshot
  drm/xe: Add xe_gt_clock_interval_to_ms helper
  drm/xe: Sample ctx timestamp to determine if jobs have timed out

 .../gpu/drm/xe/instructions/xe_mi_commands.h  |   4 +
 drivers/gpu/drm/xe/xe_gt_clock.c              |  18 ++
 drivers/gpu/drm/xe/xe_gt_clock.h              |   1 +
 drivers/gpu/drm/xe/xe_guc_submit.c            | 218 ++++++++++++++----
 drivers/gpu/drm/xe/xe_lrc.c                   |  72 ++++++
 drivers/gpu/drm/xe/xe_lrc.h                   |   5 +
 drivers/gpu/drm/xe/xe_ring_ops.c              |  21 ++
 7 files changed, 296 insertions(+), 43 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-06-08  0:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-08  0:20 Matthew Brost [this message]
2024-06-08  0:20 ` [PATCH v3 1/6] drm/xe: Add LRC ctx timestamp support functions Matthew Brost
2024-06-10 13:49   ` Lucas De Marchi
2024-06-10 14:10     ` Matthew Brost
2024-06-10 17:42       ` Lucas De Marchi
2024-06-08  0:20 ` [PATCH v3 2/6] drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions Matthew Brost
2024-06-08  0:21 ` [PATCH v3 3/6] drm/xe: Emit ctx timestamp copy in ring ops Matthew Brost
2024-06-08  0:21 ` [PATCH v3 4/6] drm/xe: Add ctx timestamp to LRC snapshot Matthew Brost
2024-06-08  0:21 ` [PATCH v3 5/6] drm/xe: Add xe_gt_clock_interval_to_ms helper Matthew Brost
2024-06-08  0:21 ` [PATCH v3 6/6] drm/xe: Sample ctx timestamp to determine if jobs have timed out Matthew Brost
2024-06-08  2:13   ` John Harrison
2024-06-08  2:29     ` Matthew Brost
2024-06-08  0:25 ` ✓ CI.Patch_applied: success for Only timeout jobs if they run longer than timeout period Patchwork
2024-06-08  0:25 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-08  0:26 ` ✓ CI.KUnit: success " Patchwork
2024-06-08  0:37 ` ✓ CI.Build: " Patchwork
2024-06-08  0:39 ` ✗ CI.Hooks: failure " Patchwork
2024-06-08  0:41 ` ✓ CI.checksparse: success " Patchwork
2024-06-08  1:27 ` ✓ CI.BAT: " Patchwork
2024-06-08 16:55 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240608002103.2371696-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox