From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH v3 1/5] drm/xe: Prefer GT oriented messages in xe_force_wake.c
Date: Tue, 11 Jun 2024 18:35:33 +0200 [thread overview]
Message-ID: <20240611163537.1944-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240611163537.1944-1-michal.wajdeczko@intel.com>
If possible, we should prefer xe_gt_notice() over drm_notice().
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
---
v2: don't fix fw_to_gt (Lucas)
---
drivers/gpu/drm/xe/xe_force_wake.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
index b2d385daff4b..13ddabd90eed 100644
--- a/drivers/gpu/drm/xe/xe_force_wake.c
+++ b/drivers/gpu/drm/xe/xe_force_wake.c
@@ -10,6 +10,7 @@
#include "regs/xe_gt_regs.h"
#include "regs/xe_reg_defs.h"
#include "xe_gt.h"
+#include "xe_gt_printk.h"
#include "xe_mmio.h"
#define XE_FORCE_WAKE_ACK_TIMEOUT_MS 50
@@ -20,12 +21,6 @@ fw_to_gt(struct xe_force_wake *fw)
return fw->gt;
}
-static struct xe_device *
-fw_to_xe(struct xe_force_wake *fw)
-{
- return gt_to_xe(fw_to_gt(fw));
-}
-
static void domain_init(struct xe_force_wake_domain *domain,
enum xe_force_wake_domain_id id,
struct xe_reg reg, struct xe_reg ack)
@@ -135,7 +130,6 @@ static int domain_sleep_wait(struct xe_gt *gt,
int xe_force_wake_get(struct xe_force_wake *fw,
enum xe_force_wake_domains domains)
{
- struct xe_device *xe = fw_to_xe(fw);
struct xe_gt *gt = fw_to_gt(fw);
struct xe_force_wake_domain *domain;
enum xe_force_wake_domains tmp, woken = 0;
@@ -153,8 +147,8 @@ int xe_force_wake_get(struct xe_force_wake *fw,
ret = domain_wake_wait(gt, domain);
ret2 |= ret;
if (ret)
- drm_notice(&xe->drm, "Force wake domain (%d) failed to ack wake, ret=%d\n",
- domain->id, ret);
+ xe_gt_notice(gt, "Force wake domain (%d) failed to ack wake, ret=%d\n",
+ domain->id, ret);
}
fw->awake_domains |= woken;
spin_unlock_irqrestore(&fw->lock, flags);
@@ -165,7 +159,6 @@ int xe_force_wake_get(struct xe_force_wake *fw,
int xe_force_wake_put(struct xe_force_wake *fw,
enum xe_force_wake_domains domains)
{
- struct xe_device *xe = fw_to_xe(fw);
struct xe_gt *gt = fw_to_gt(fw);
struct xe_force_wake_domain *domain;
enum xe_force_wake_domains tmp, sleep = 0;
@@ -183,8 +176,8 @@ int xe_force_wake_put(struct xe_force_wake *fw,
ret = domain_sleep_wait(gt, domain);
ret2 |= ret;
if (ret)
- drm_notice(&xe->drm, "Force wake domain (%d) failed to ack sleep, ret=%d\n",
- domain->id, ret);
+ xe_gt_notice(gt, "Force wake domain (%d) failed to ack sleep, ret=%d\n",
+ domain->id, ret);
}
fw->awake_domains &= ~sleep;
spin_unlock_irqrestore(&fw->lock, flags);
--
2.43.0
next prev parent reply other threads:[~2024-06-11 16:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 16:35 [PATCH v3 0/5] Prepare Xe force-wake code for VFs Michal Wajdeczko
2024-06-11 16:35 ` Michal Wajdeczko [this message]
2024-06-12 10:11 ` [PATCH v3 1/5] drm/xe: Prefer GT oriented messages in xe_force_wake.c Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 2/5] drm/xe: Kill fw_to_gt() helper Michal Wajdeczko
2024-06-11 16:41 ` Francois Dugast
2024-06-12 10:12 ` Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 3/5] drm/xe: Include additional info on failed force-wake operation Michal Wajdeczko
2024-06-11 17:04 ` Rodrigo Vivi
2024-06-12 10:13 ` Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 4/5] drm/xe: Combine common force-wake code into helpers Michal Wajdeczko
2024-06-12 10:14 ` Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 5/5] drm/xe/vf: Ignore force-wake requests if VF Michal Wajdeczko
2024-06-12 10:15 ` Nirmoy Das
2024-06-11 17:36 ` ✓ CI.Patch_applied: success for Prepare Xe force-wake code for VFs (rev4) Patchwork
2024-06-11 17:36 ` ✓ CI.checkpatch: " Patchwork
2024-06-11 17:37 ` ✓ CI.KUnit: " Patchwork
2024-06-11 17:49 ` ✓ CI.Build: " Patchwork
2024-06-11 17:51 ` ✗ CI.Hooks: failure " Patchwork
2024-06-11 17:53 ` ✓ CI.checksparse: success " Patchwork
2024-06-11 18:34 ` ✓ CI.BAT: " Patchwork
2024-06-11 22:27 ` ✗ CI.FULL: failure " Patchwork
2024-06-12 9:54 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611163537.1944-2-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox