From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v3 5/5] drm/xe/vf: Ignore force-wake requests if VF
Date: Tue, 11 Jun 2024 18:35:37 +0200 [thread overview]
Message-ID: <20240611163537.1944-6-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240611163537.1944-1-michal.wajdeczko@intel.com>
The control and ack force-wake registers are not accessible for
the VF drivers. To avoid changing existing code logic that tracks
woken domains, simply ignore all attempts to access control or ack
registers if we are running as a VF driver.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/xe_force_wake.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
index 468aabd72d6b..5db6926120c3 100644
--- a/drivers/gpu/drm/xe/xe_force_wake.c
+++ b/drivers/gpu/drm/xe/xe_force_wake.c
@@ -12,6 +12,7 @@
#include "xe_gt.h"
#include "xe_gt_printk.h"
#include "xe_mmio.h"
+#include "xe_sriov.h"
#define XE_FORCE_WAKE_ACK_TIMEOUT_MS 50
@@ -96,6 +97,9 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct xe_force_wake *fw)
static void __domain_ctl(struct xe_gt *gt, struct xe_force_wake_domain *domain, bool wake)
{
+ if (IS_SRIOV(gt_to_xe(gt)))
+ return;
+
xe_mmio_write32(gt, domain->reg_ctl, domain->mask | (wake ? domain->val : 0));
}
@@ -104,6 +108,9 @@ static int __domain_wait(struct xe_gt *gt, struct xe_force_wake_domain *domain,
u32 value;
int ret;
+ if (IS_SRIOV(gt_to_xe(gt)))
+ return 0;
+
ret = xe_mmio_wait32(gt, domain->reg_ack, domain->val, wake ? domain->val : 0,
XE_FORCE_WAKE_ACK_TIMEOUT_MS * USEC_PER_MSEC,
&value, true);
--
2.43.0
next prev parent reply other threads:[~2024-06-11 16:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 16:35 [PATCH v3 0/5] Prepare Xe force-wake code for VFs Michal Wajdeczko
2024-06-11 16:35 ` [PATCH v3 1/5] drm/xe: Prefer GT oriented messages in xe_force_wake.c Michal Wajdeczko
2024-06-12 10:11 ` Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 2/5] drm/xe: Kill fw_to_gt() helper Michal Wajdeczko
2024-06-11 16:41 ` Francois Dugast
2024-06-12 10:12 ` Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 3/5] drm/xe: Include additional info on failed force-wake operation Michal Wajdeczko
2024-06-11 17:04 ` Rodrigo Vivi
2024-06-12 10:13 ` Nirmoy Das
2024-06-11 16:35 ` [PATCH v3 4/5] drm/xe: Combine common force-wake code into helpers Michal Wajdeczko
2024-06-12 10:14 ` Nirmoy Das
2024-06-11 16:35 ` Michal Wajdeczko [this message]
2024-06-12 10:15 ` [PATCH v3 5/5] drm/xe/vf: Ignore force-wake requests if VF Nirmoy Das
2024-06-11 17:36 ` ✓ CI.Patch_applied: success for Prepare Xe force-wake code for VFs (rev4) Patchwork
2024-06-11 17:36 ` ✓ CI.checkpatch: " Patchwork
2024-06-11 17:37 ` ✓ CI.KUnit: " Patchwork
2024-06-11 17:49 ` ✓ CI.Build: " Patchwork
2024-06-11 17:51 ` ✗ CI.Hooks: failure " Patchwork
2024-06-11 17:53 ` ✓ CI.checksparse: success " Patchwork
2024-06-11 18:34 ` ✓ CI.BAT: " Patchwork
2024-06-11 22:27 ` ✗ CI.FULL: failure " Patchwork
2024-06-12 9:54 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611163537.1944-6-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox