From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH] drm/i915/display: Workaround for odd panning for planar yuv
Date: Tue, 10 Sep 2024 20:07:57 +0530 [thread overview]
Message-ID: <20240910143757.143614-1-nemesa.garg@intel.com> (raw)
Disable the support for odd x pan for NV12 format as underrun
issue is seen.
WA: 16024459452
v2: Replace HSD with WA in commit message [Suraj]
Modified the condition for handling odd panning
v3: Simplified the condition for checking hsub
Using older framework for wa as rev1[Jani]
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index e979786aa5cf..4afe808f128c 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -1029,8 +1029,13 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
* This allows NV12 and P0xx formats to have odd size and/or odd
* source coordinates on DISPLAY_VER(i915) >= 20
*/
- hsub = 1;
vsub = 1;
+ /*
+ * Wa_16023981245 for display version 20.
+ * Do not support odd x-panning for NV12.
+ */
+ if (IS_LUNARLAKE(i915) && fb->format->format != DRM_FORMAT_NV12)
+ hsub = 1;
} else {
hsub = fb->format->hsub;
vsub = fb->format->vsub;
--
2.25.1
next reply other threads:[~2024-09-10 14:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 14:37 Nemesa Garg [this message]
2024-09-10 16:36 ` [PATCH] drm/i915/display: Workaround for odd panning for planar yuv Pottumuttu, Sai Teja
2024-09-25 7:49 ` Garg, Nemesa
2024-09-10 17:02 ` ✓ CI.Patch_applied: success for drm/i915/display: Workaround for odd panning for planar yuv (rev3) Patchwork
2024-09-10 17:03 ` ✓ CI.checkpatch: " Patchwork
2024-09-10 17:04 ` ✓ CI.KUnit: " Patchwork
2024-09-10 17:16 ` ✓ CI.Build: " Patchwork
2024-09-10 17:18 ` ✓ CI.Hooks: " Patchwork
2024-09-10 17:19 ` ✗ CI.checksparse: warning " Patchwork
2024-09-10 18:02 ` ✗ CI.BAT: failure " Patchwork
2024-09-10 21:08 ` ✗ CI.FULL: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-30 11:21 [PATCH] drm/i915/display: Workaround for odd panning for planar yuv Nemesa Garg
2024-10-16 7:24 ` Nemesa Garg
2024-10-17 8:05 ` Kandpal, Suraj
2024-10-17 16:53 ` Pottumuttu, Sai Teja
2024-10-18 5:04 ` Garg, Nemesa
2024-10-18 5:05 ` Garg, Nemesa
2024-10-18 5:44 ` Chauhan, Shekhar
2024-10-18 17:36 ` Matt Roper
2024-09-25 12:25 Nemesa Garg
2024-09-25 13:09 ` Jani Nikula
2024-09-25 13:57 ` Pottumuttu, Sai Teja
2024-09-06 7:01 Nemesa Garg
2024-09-06 8:51 ` Jani Nikula
2024-09-06 9:07 ` Jani Nikula
2024-09-06 13:51 ` Lucas De Marchi
2024-09-06 14:18 ` Jani Nikula
2024-09-06 15:33 ` Rodrigo Vivi
2024-07-24 13:06 Nemesa Garg
2024-07-24 17:01 ` Kandpal, Suraj
2024-07-25 2:59 ` Kandpal, Suraj
2024-08-12 5:18 ` Garg, Nemesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910143757.143614-1-nemesa.garg@intel.com \
--to=nemesa.garg@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox