Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH] drm/i915/display: Workaround for odd panning for planar yuv
Date: Wed, 16 Oct 2024 12:54:36 +0530	[thread overview]
Message-ID: <20241016072436.261438-1-nemesa.garg@intel.com> (raw)
In-Reply-To: <20240930112146.2673086-1-nemesa.garg@intel.com>

Disable the support for odd x pan for even xsize for NV12
format as underrun issue is seen.

WA: 16024459452

v2: Replace HSD with WA in commit message [Suraj]
    Modified the condition for handling odd panning

v3: Simplified the condition for checking hsub
    Using older framework for wa as rev1[Jani]

v4: Modify the condition for hsub [Sai Teja]
    Initialize hsub in else path [Dan]

v5: Replace IS_LUNARLAKE with display version.
    Resolve nitpicks[Jani]

v6: Replace -EINVAL with hsub [Suraj]
    Remove src_w check as not required

Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index e979786aa5cf..2d7ca6e62926 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -1031,6 +1031,11 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
 		 */
 		hsub = 1;
 		vsub = 1;
+
+		/* Wa_16023981245 */
+		if (DISPLAY_VER(i915) == 20 && fb->format->format == DRM_FORMAT_NV12 &&
+		    src_x % 2 != 0)
+			hsub = 2;
 	} else {
 		hsub = fb->format->hsub;
 		vsub = fb->format->vsub;
-- 
2.25.1


  parent reply	other threads:[~2024-10-16  7:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 11:21 [PATCH] drm/i915/display: Workaround for odd panning for planar yuv Nemesa Garg
2024-09-30 11:28 ` ✓ CI.Patch_applied: success for drm/i915/display: Workaround for odd panning for planar yuv (rev5) Patchwork
2024-09-30 11:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-30 11:31 ` ✓ CI.KUnit: success " Patchwork
2024-09-30 11:47 ` ✓ CI.Build: " Patchwork
2024-09-30 11:49 ` ✓ CI.Hooks: " Patchwork
2024-09-30 11:51 ` ✗ CI.checksparse: warning " Patchwork
2024-09-30 12:31 ` ✓ CI.BAT: success " Patchwork
2024-09-30 13:45 ` ✗ CI.FULL: failure " Patchwork
2024-10-16  7:24 ` Nemesa Garg [this message]
2024-10-17  8:05   ` [PATCH] drm/i915/display: Workaround for odd panning for planar yuv Kandpal, Suraj
2024-10-17 16:53     ` Pottumuttu, Sai Teja
2024-10-18  5:04       ` Garg, Nemesa
2024-10-18  5:05         ` Garg, Nemesa
2024-10-18  5:44         ` Chauhan, Shekhar
2024-10-18 17:36           ` Matt Roper
2024-10-16  9:53 ` ✓ CI.Patch_applied: success for drm/i915/display: Workaround for odd panning for planar yuv (rev6) Patchwork
2024-10-16  9:53 ` ✓ CI.checkpatch: " Patchwork
2024-10-16  9:54 ` ✓ CI.KUnit: " Patchwork
2024-10-16 10:06 ` ✓ CI.Build: " Patchwork
2024-10-16 10:08 ` ✓ CI.Hooks: " Patchwork
2024-10-16 10:10 ` ✗ CI.checksparse: warning " Patchwork
2024-10-16 10:51 ` ✓ CI.BAT: success " Patchwork
2024-10-16 22:34 ` ✗ CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-09-25 12:25 [PATCH] drm/i915/display: Workaround for odd panning for planar yuv Nemesa Garg
2024-09-25 13:09 ` Jani Nikula
2024-09-25 13:57 ` Pottumuttu, Sai Teja
2024-09-10 14:37 Nemesa Garg
2024-09-10 16:36 ` Pottumuttu, Sai Teja
2024-09-25  7:49   ` Garg, Nemesa
2024-09-06  7:01 Nemesa Garg
2024-09-06  8:51 ` Jani Nikula
2024-09-06  9:07   ` Jani Nikula
2024-09-06 13:51   ` Lucas De Marchi
2024-09-06 14:18     ` Jani Nikula
2024-09-06 15:33       ` Rodrigo Vivi
2024-07-24 13:06 Nemesa Garg
2024-07-24 17:01 ` Kandpal, Suraj
2024-07-25  2:59   ` Kandpal, Suraj
2024-08-12  5:18     ` Garg, Nemesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016072436.261438-1-nemesa.garg@intel.com \
    --to=nemesa.garg@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox