Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
	ville.syrjala@linux.intel.com
Subject: [PATCH 03/15] drm/i915/display_debugfs: Allow force joiner only if supported
Date: Wed, 18 Sep 2024 20:13:31 +0530	[thread overview]
Message-ID: <20240918144343.2876184-4-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240918144343.2876184-1-ankit.k.nautiyal@intel.com>

Currently we support joiner only for DP encoder.
Do not create the debugfs for joiner if DP does not support the joiner.
This will also help avoiding cases where config has eDP MSO, with which
we do not support joiner.

v2: Check for intel_dp_has_joiner and avoid creating debugfs if not
supported. (Ville)

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 86403a9318b0..cda3f6cf724d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1516,6 +1516,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
 	struct drm_i915_private *i915 = to_i915(connector->base.dev);
 	struct dentry *root = connector->base.debugfs_entry;
 	int connector_type = connector->base.connector_type;
+	struct intel_dp *intel_dp = intel_attached_dp(connector);
 
 	/* The connector must have been registered beforehands. */
 	if (!root)
@@ -1550,7 +1551,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
 				    connector, &i915_dsc_fractional_bpp_fops);
 	}
 
-	if (HAS_BIGJOINER(i915) &&
+	if (HAS_BIGJOINER(i915) && intel_dp_has_joiner(intel_dp) &&
 	    (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
 	     connector_type == DRM_MODE_CONNECTOR_eDP)) {
 		debugfs_create_bool("i915_bigjoiner_force_enable", 0644, root,
-- 
2.45.2


  parent reply	other threads:[~2024-09-18 14:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 14:43 [PATCH 00/15] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-18 14:43 ` [PATCH 01/15] drm/i915: Add some essential functionality for joiners Ankit Nautiyal
2024-09-18 14:43 ` [PATCH 02/15] drm/i915/display: Enhance iterators for modeset en/disable Ankit Nautiyal
2024-09-18 14:43 ` Ankit Nautiyal [this message]
2024-09-19 15:04   ` [PATCH 03/15] drm/i915/display_debugfs: Allow force joiner only if supported Ville Syrjälä
2024-09-18 14:43 ` [PATCH 04/15] drm/i915/display: Modify debugfs for joiner to force n pipes Ankit Nautiyal
2024-09-19 15:07   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 05/15] drm/i915/dp: Add helper to compute num pipes required Ankit Nautiyal
2024-09-19 15:12   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 06/15] drm/i915/display: Add debugfs support to avoid joiner Ankit Nautiyal
2024-09-19 15:15   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 07/15] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-19 15:18   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 08/15] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-19 15:22   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 09/15] drm/i915/display: Add macro HAS_ULTRAJOINER() Ankit Nautiyal
2024-09-19 15:24   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 10/15] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-19 15:33   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 11/15] drm/i915/display: Refactor enable_joiner_pipes Ankit Nautiyal
2024-09-19 18:02   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 12/15] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-19 18:06   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 13/15] drm/i915: Compute config and mode valid changes for ultrajoiner Ankit Nautiyal
2024-09-19 18:30   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 14/15] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-19 18:42   ` Ville Syrjälä
2024-09-18 14:43 ` [PATCH 15/15] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-19 18:45   ` Ville Syrjälä
2024-09-18 16:28 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series Patchwork
2024-09-18 16:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-18 16:30 ` ✓ CI.KUnit: success " Patchwork
2024-09-18 16:42 ` ✓ CI.Build: " Patchwork
2024-09-18 16:44 ` ✓ CI.Hooks: " Patchwork
2024-09-18 16:46 ` ✗ CI.checksparse: warning " Patchwork
2024-09-18 17:10 ` ✓ CI.BAT: success " Patchwork
2024-09-19  1:52 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240918144343.2876184-4-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox