From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
jani.nikula@linux.intel.com
Subject: [PATCH 6/7] drm/i915/dp: Use clamp for pipe_bpp limits with DSC
Date: Thu, 3 Oct 2024 16:13:42 +0530 [thread overview]
Message-ID: <20241003104343.984060-7-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20241003104343.984060-1-ankit.k.nautiyal@intel.com>
Currently to get the max pipe_bpp with dsc we take the min of
limits->pipe.max_bpp and dsc max bpp (dsc max bpc * 3). This can result
in problems when limits->pipe.max_bpp is less than the computed dsc min bpp
(dsc min bpc * 3).
Replace the min/max functions with clamp while computing
limits->pipe.max/min_bpp to ensure that the pipe_bpp limits are constrained
within the DSC-defined minimum and maximum values.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 55ee438a4fec..02009ae03840 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2490,8 +2490,11 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
int dsc_min_bpc = intel_dp_dsc_min_src_input_bpc(display);
int dsc_max_bpc = intel_dp_dsc_max_src_input_bpc(display);
- limits->pipe.max_bpp = min(limits->pipe.max_bpp, dsc_max_bpc * 3);
- limits->pipe.min_bpp = max(limits->pipe.min_bpp, dsc_min_bpc * 3);
+ limits->pipe.max_bpp = clamp(limits->pipe.max_bpp,
+ dsc_min_bpc * 3, dsc_max_bpc * 3);
+
+ limits->pipe.min_bpp = clamp(limits->pipe.min_bpp,
+ dsc_min_bpc * 3, dsc_max_bpc * 3);
}
if (intel_dp->use_max_params) {
--
2.45.2
next prev parent reply other threads:[~2024-10-03 10:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 10:43 [PATCH 0/7] DP DSC min/max src bpc fixes Ankit Nautiyal
2024-10-03 10:43 ` [PATCH 1/7] drm/i915/dp: Use HAS_DSC macro in intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
2024-10-03 11:04 ` Kandpal, Suraj
2024-10-17 12:13 ` Imre Deak
2024-11-15 8:10 ` Nautiyal, Ankit K
2024-10-03 10:43 ` [PATCH 2/7] drm/i915/dp: Return int from dsc_max/min_src_input_bpc helpers Ankit Nautiyal
2024-10-03 10:43 ` [PATCH 3/7] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc Ankit Nautiyal
2024-10-03 10:43 ` [PATCH 4/7] drm/i915/dp: Drop max_requested_bpc for dsc pipe_min/max bpp Ankit Nautiyal
2024-10-13 15:35 ` Kandpal, Suraj
2024-10-03 10:43 ` [PATCH 5/7] drm/i915/dp: Refactor pipe_bpp limits with dsc Ankit Nautiyal
2024-10-13 15:37 ` Kandpal, Suraj
2024-10-17 12:20 ` Imre Deak
2024-11-15 8:13 ` Nautiyal, Ankit K
2024-11-15 8:25 ` Nautiyal, Ankit K
2024-10-03 10:43 ` Ankit Nautiyal [this message]
2024-10-13 15:39 ` [PATCH 6/7] drm/i915/dp: Use clamp for pipe_bpp limits with DSC Kandpal, Suraj
2024-10-03 10:43 ` [PATCH 7/7] drm/i915/dp: Set the DSC link limits intel_dp_compute_config_link_bpp_limits Ankit Nautiyal
2024-10-13 15:46 ` Kandpal, Suraj
2024-10-15 6:15 ` Kandpal, Suraj
2024-10-17 12:42 ` Imre Deak
2024-11-15 8:28 ` Nautiyal, Ankit K
2024-10-03 10:49 ` ✓ CI.Patch_applied: success for DP DSC min/max src bpc fixes Patchwork
2024-10-03 10:49 ` ✓ CI.checkpatch: " Patchwork
2024-10-03 10:50 ` ✓ CI.KUnit: " Patchwork
2024-10-03 11:03 ` ✓ CI.Build: " Patchwork
2024-10-03 11:05 ` ✓ CI.Hooks: " Patchwork
2024-10-03 11:07 ` ✗ CI.checksparse: warning " Patchwork
2024-10-03 11:31 ` ✓ CI.BAT: success " Patchwork
2024-10-03 12:30 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003104343.984060-7-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox