From: fei.yang@intel.com
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, Fei Yang <fei.yang@intel.com>,
John Harrison <John.C.Harrison@Intel.com>
Subject: [PATCH 1/1] drm/xe: enable lite restore
Date: Thu, 17 Oct 2024 09:27:10 -0700 [thread overview]
Message-ID: <20241017162710.942553-2-fei.yang@intel.com> (raw)
In-Reply-To: <20241017162710.942553-1-fei.yang@intel.com>
From: Fei Yang <fei.yang@intel.com>
The lite restore is a performance improvement feature which avoids
unnecessary context switch (flush, save and rstore) if the incoming
context has a ContextID matching that of the outgoing context. The
scheduling is done by the Guc firmware, so on the driver side it's
just a matter of setting corresponding GuC_CTL_FEATURE flag.
This is supposed to be enabled by default, thus the flag is set
unconditionally.
Signed-off-by: Fei Yang <fei.yang@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
---
drivers/gpu/drm/xe/xe_guc.c | 2 +-
drivers/gpu/drm/xe/xe_guc_fwif.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 76437d42b8a1..04e50eb6e506 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -70,7 +70,7 @@ static u32 guc_ctl_debug_flags(struct xe_guc *guc)
static u32 guc_ctl_feature_flags(struct xe_guc *guc)
{
- u32 flags = 0;
+ u32 flags = GUC_CTL_ENABLE_LITE_RESTORE;
if (!guc_to_xe(guc)->info.skip_guc_pc)
flags |= GUC_CTL_ENABLE_SLPC;
diff --git a/drivers/gpu/drm/xe/xe_guc_fwif.h b/drivers/gpu/drm/xe/xe_guc_fwif.h
index 01e3ab590c3a..08ffe59f22fa 100644
--- a/drivers/gpu/drm/xe/xe_guc_fwif.h
+++ b/drivers/gpu/drm/xe/xe_guc_fwif.h
@@ -105,6 +105,7 @@ struct guc_update_exec_queue_policy {
#define GUC_CTL_FEATURE 2
#define GUC_CTL_ENABLE_SLPC BIT(2)
+#define GUC_CTL_ENABLE_LITE_RESTORE BIT(4)
#define GUC_CTL_DISABLE_SCHEDULER BIT(14)
#define GUC_CTL_DEBUG 3
--
2.25.1
next prev parent reply other threads:[~2024-10-17 16:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 16:27 [PATCH 0/1] drm/xe: enable lite restore fei.yang
2024-10-17 16:27 ` fei.yang [this message]
2024-10-17 16:42 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-17 16:42 ` ✓ CI.checkpatch: " Patchwork
2024-10-17 16:43 ` ✓ CI.KUnit: " Patchwork
2024-10-17 16:55 ` ✓ CI.Build: " Patchwork
2024-10-17 16:57 ` ✓ CI.Hooks: " Patchwork
2024-10-17 16:59 ` ✓ CI.checksparse: " Patchwork
2024-10-17 17:25 ` ✗ CI.BAT: failure " Patchwork
2024-10-18 8:12 ` ✗ CI.FULL: " Patchwork
2024-10-18 17:28 ` ✓ CI.Patch_applied: success for drm/xe: enable lite restore (rev2) Patchwork
2024-10-18 17:28 ` ✓ CI.checkpatch: " Patchwork
2024-10-18 17:29 ` ✓ CI.KUnit: " Patchwork
2024-10-18 17:41 ` ✓ CI.Build: " Patchwork
2024-10-18 17:43 ` ✓ CI.Hooks: " Patchwork
2024-10-18 17:45 ` ✓ CI.checksparse: " Patchwork
2024-10-18 18:03 ` ✓ CI.BAT: " Patchwork
2024-10-19 9:38 ` ✗ CI.FULL: failure " Patchwork
2024-10-20 7:30 ` ✓ CI.Patch_applied: success for drm/xe: enable lite restore (rev3) Patchwork
2024-10-20 7:30 ` ✓ CI.checkpatch: " Patchwork
2024-10-20 7:31 ` ✓ CI.KUnit: " Patchwork
2024-10-20 7:43 ` ✓ CI.Build: " Patchwork
2024-10-20 7:45 ` ✓ CI.Hooks: " Patchwork
2024-10-20 7:47 ` ✓ CI.checksparse: " Patchwork
2024-10-20 8:12 ` ✓ CI.BAT: " Patchwork
2024-10-20 9:11 ` ✗ CI.FULL: failure " Patchwork
2024-10-24 17:48 ` [PATCH 0/1] drm/xe: enable lite restore Ngai-Mint Kwan
-- strict thread matches above, loose matches on Subject: below --
2024-10-16 22:37 fei.yang
2024-10-16 22:37 ` [PATCH 1/1] " fei.yang
2024-10-16 18:57 [PATCH 0/1] " fei.yang
2024-10-16 18:57 ` [PATCH 1/1] " fei.yang
2024-10-16 19:13 ` Souza, Jose
2024-10-16 22:39 ` Yang, Fei
2024-10-10 17:31 [PATCH 0/1] " fei.yang
2024-10-10 17:31 ` [PATCH 1/1] " fei.yang
2024-10-10 17:32 ` John Harrison
2024-10-11 13:47 ` Lucas De Marchi
2024-10-16 18:50 ` Yang, Fei
2024-10-08 23:30 [PATCH 0/1] " fei.yang
2024-10-08 23:30 ` [PATCH 1/1] " fei.yang
2024-10-09 20:12 ` John Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017162710.942553-2-fei.yang@intel.com \
--to=fei.yang@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox