Re: [PATCH 1/1] drm/xe: enable lite restore

[John Harrison <john.c.harrison@intel.com>]

On 10/8/2024 16:30, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
>
> The lite restore feature is supposed to be enabled by default.
>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc.c      | 2 ++
>   drivers/gpu/drm/xe/xe_guc_fwif.h | 1 +
>   2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 8570b1218287..e1dad02b0770 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -75,6 +75,8 @@ static u32 guc_ctl_feature_flags(struct xe_guc *guc)
>   	if (!guc_to_xe(guc)->info.skip_guc_pc)
>   		flags |= GUC_CTL_ENABLE_SLPC;
>   
> +	flags |= GUC_CTL_ENABLE_LITE_RESTORE;
> +
Given that this is unconditional, you could put this before the 
conditional one and make it a straight assignment (and drop the =0 from 
the declaration line).

john.

>   	return flags;
>   }
>   
> diff --git a/drivers/gpu/drm/xe/xe_guc_fwif.h b/drivers/gpu/drm/xe/xe_guc_fwif.h
> index 01e3ab590c3a..08ffe59f22fa 100644
> --- a/drivers/gpu/drm/xe/xe_guc_fwif.h
> +++ b/drivers/gpu/drm/xe/xe_guc_fwif.h
> @@ -105,6 +105,7 @@ struct guc_update_exec_queue_policy {
>   
>   #define GUC_CTL_FEATURE			2
>   #define   GUC_CTL_ENABLE_SLPC		BIT(2)
> +#define   GUC_CTL_ENABLE_LITE_RESTORE	BIT(4)
>   #define   GUC_CTL_DISABLE_SCHEDULER	BIT(14)
>   
>   #define GUC_CTL_DEBUG			3