Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Yang,  Fei" <fei.yang@intel.com>
Subject: Re: [PATCH 1/1] drm/xe: enable lite restore
Date: Wed, 16 Oct 2024 19:13:31 +0000	[thread overview]
Message-ID: <382341ca84abda4653f56b99690a9a63de882a35.camel@intel.com> (raw)
In-Reply-To: <20241016185726.907844-2-fei.yang@intel.com>

On Wed, 2024-10-16 at 11:57 -0700, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
> 
> The lite restore is a performance improvement feature which avoids
> unnecessary full context save and restore if the task been switched
> in is the same as the one been switched out. This is supposed to be
> enabled by default.

in the same what? engine?
please append that to commit message.

> 
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc.c      | 2 +-
>  drivers/gpu/drm/xe/xe_guc_fwif.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 8570b1218287..fed30f2872f7 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -70,7 +70,7 @@ static u32 guc_ctl_debug_flags(struct xe_guc *guc)
>  
>  static u32 guc_ctl_feature_flags(struct xe_guc *guc)
>  {
> -	u32 flags = 0;
> +	u32 flags = GUC_CTL_ENABLE_LITE_RESTORE;
>  
>  	if (!guc_to_xe(guc)->info.skip_guc_pc)
>  		flags |= GUC_CTL_ENABLE_SLPC;
> diff --git a/drivers/gpu/drm/xe/xe_guc_fwif.h b/drivers/gpu/drm/xe/xe_guc_fwif.h
> index 01e3ab590c3a..08ffe59f22fa 100644
> --- a/drivers/gpu/drm/xe/xe_guc_fwif.h
> +++ b/drivers/gpu/drm/xe/xe_guc_fwif.h
> @@ -105,6 +105,7 @@ struct guc_update_exec_queue_policy {
>  
>  #define GUC_CTL_FEATURE			2
>  #define   GUC_CTL_ENABLE_SLPC		BIT(2)
> +#define   GUC_CTL_ENABLE_LITE_RESTORE	BIT(4)
>  #define   GUC_CTL_DISABLE_SCHEDULER	BIT(14)
>  
>  #define GUC_CTL_DEBUG			3


  reply	other threads:[~2024-10-16 19:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 18:57 [PATCH 0/1] drm/xe: enable lite restore fei.yang
2024-10-16 18:57 ` [PATCH 1/1] " fei.yang
2024-10-16 19:13   ` Souza, Jose [this message]
2024-10-16 22:39     ` Yang, Fei
2024-10-16 18:58 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-16 18:58 ` ✓ CI.checkpatch: " Patchwork
2024-10-16 18:59 ` ✓ CI.KUnit: " Patchwork
2024-10-16 19:11 ` ✓ CI.Build: " Patchwork
2024-10-16 19:13 ` ✓ CI.Hooks: " Patchwork
2024-10-16 19:15 ` ✓ CI.checksparse: " Patchwork
2024-10-16 19:39 ` ✓ CI.BAT: " Patchwork
2024-10-17  9:46 ` ✗ CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-10-17 16:27 [PATCH 0/1] " fei.yang
2024-10-17 16:27 ` [PATCH 1/1] " fei.yang
2024-10-16 22:37 [PATCH 0/1] " fei.yang
2024-10-16 22:37 ` [PATCH 1/1] " fei.yang
2024-10-10 17:31 [PATCH 0/1] " fei.yang
2024-10-10 17:31 ` [PATCH 1/1] " fei.yang
2024-10-10 17:32   ` John Harrison
2024-10-11 13:47   ` Lucas De Marchi
2024-10-16 18:50     ` Yang, Fei
2024-10-08 23:30 [PATCH 0/1] " fei.yang
2024-10-08 23:30 ` [PATCH 1/1] " fei.yang
2024-10-09 20:12   ` John Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=382341ca84abda4653f56b99690a9a63de882a35.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=fei.yang@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox