Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clint Taylor <clinton.a.taylor@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [PATCH v5 07/11] drm/i915/xe3lpd: Move async flip bit to PLANE_SURF register
Date: Fri, 25 Oct 2024 13:47:39 -0700	[thread overview]
Message-ID: <20241025204743.211510-8-clinton.a.taylor@intel.com> (raw)
In-Reply-To: <20241025204743.211510-1-clinton.a.taylor@intel.com>

From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

The async flip moved from PLANE_CTL to PLANE_SURF for Xe3_LPD.

Bspec: 69853,69878
Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: Clint Taylor <Clinton.A.Taylor@intel.com>
Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
 drivers/gpu/drm/i915/display/skl_universal_plane.c  | 13 +++++++++----
 .../gpu/drm/i915/display/skl_universal_plane_regs.h |  1 +
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index a0a7ed01415a..60ca4f8c4a3c 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1567,17 +1567,22 @@ skl_plane_async_flip(struct intel_dsb *dsb,
 	struct intel_display *display = to_intel_display(plane->base.dev);
 	enum plane_id plane_id = plane->id;
 	enum pipe pipe = plane->pipe;
-	u32 plane_ctl = plane_state->ctl;
+	u32 plane_ctl = plane_state->ctl, plane_surf;
 
 	plane_ctl |= skl_plane_ctl_crtc(crtc_state);
+	plane_surf = skl_plane_surf(plane_state, 0);
 
-	if (async_flip)
-		plane_ctl |= PLANE_CTL_ASYNC_FLIP;
+	if (async_flip) {
+		if (DISPLAY_VER(display) >= 30)
+			plane_surf |= PLANE_SURF_ASYNC_UPDATE;
+		else
+			plane_ctl |= PLANE_CTL_ASYNC_FLIP;
+	}
 
 	intel_de_write_dsb(display, dsb, PLANE_CTL(pipe, plane_id),
 			   plane_ctl);
 	intel_de_write_dsb(display, dsb, PLANE_SURF(pipe, plane_id),
-			   skl_plane_surf(plane_state, 0));
+			   plane_surf);
 }
 
 static bool intel_format_is_p01x(u32 format)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h b/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h
index 4ddcd7d46bbd..ff31a00d511e 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h
@@ -159,6 +159,7 @@
 							_PLANE_SURF_2_A, _PLANE_SURF_2_B)
 #define   PLANE_SURF_ADDR_MASK			REG_GENMASK(31, 12)
 #define   PLANE_SURF_DECRYPT			REG_BIT(2)
+#define   PLANE_SURF_ASYNC_UPDATE		REG_BIT(0)
 
 #define _PLANE_KEYMAX_1_A			0x701a0
 #define _PLANE_KEYMAX_2_A			0x702a0
-- 
2.25.1


  parent reply	other threads:[~2024-10-25 20:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 20:47 [PATCH v5 00/11] drm/i915/xe3lpd: ptl display patches Clint Taylor
2024-10-25 20:47 ` [PATCH v5 01/11] drm/i915/xe3lpd: Update pmdemand programming Clint Taylor
2024-10-28 15:19   ` Govindapillai, Vinod
2024-10-28 16:25     ` Gustavo Sousa
2024-10-25 20:47 ` [PATCH v5 02/11] drm/i915/xe3lpd: Disable HDCP Line Rekeying for Xe3 Clint Taylor
2024-10-25 23:13   ` Matt Roper
2024-10-25 20:47 ` [PATCH v5 03/11] drm/i915/xe3lpd: Add check to see if edp over type c is allowed Clint Taylor
2024-10-25 20:47 ` [PATCH v5 04/11] drm/i915/ptl: Define IS_PANTHERLAKE macro Clint Taylor
2024-10-25 20:47 ` [PATCH v5 05/11] drm/i915/cx0: Extend C10 check to PTL Clint Taylor
2024-10-25 20:47 ` [PATCH v5 06/11] drm/i915/cx0: Remove bus reset after every c10 transaction Clint Taylor
2024-10-28 16:30   ` Gustavo Sousa
2024-10-25 20:47 ` Clint Taylor [this message]
2024-10-25 20:47 ` [PATCH v5 08/11] drm/i915/xe3: Underrun recovery does not exist post Xe2 Clint Taylor
2024-10-25 20:47 ` [PATCH v5 09/11] drm/i915/display/xe3: disable x-tiled framebuffers Clint Taylor
2024-10-25 20:47 ` [PATCH v5 10/11] drm/i915/xe3lpd: Power request asserting/deasserting Clint Taylor
2024-10-28 16:39   ` Gustavo Sousa
2024-10-25 20:47 ` [PATCH v5 11/11] drm/xe/ptl: Enable PTL display Clint Taylor
2024-10-28 18:45   ` Saarinen, Jani
2024-10-28 19:12   ` Rodrigo Vivi
2024-10-28 19:17   ` Matt Roper
2024-10-25 20:53 ` ✓ CI.Patch_applied: success for drm/i915/xe3lpd: ptl display patches (rev5) Patchwork
2024-10-25 20:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25 20:55 ` ✓ CI.KUnit: success " Patchwork
2024-10-25 21:12 ` ✓ CI.Build: " Patchwork
2024-10-25 21:16 ` ✓ CI.Hooks: " Patchwork
2024-10-25 21:18 ` ✗ CI.checksparse: warning " Patchwork
2024-10-25 22:09 ` ✗ CI.BAT: failure " Patchwork
2024-10-27 12:20 ` ✗ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025204743.211510-8-clinton.a.taylor@intel.com \
    --to=clinton.a.taylor@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox