From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH 1/4] drm/xe/guc: Log content of the failed G2H message
Date: Tue, 5 Nov 2024 18:30:29 +0100 [thread overview]
Message-ID: <20241105173032.1947-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20241105173032.1947-1-michal.wajdeczko@intel.com>
We are already logging an error once we failed to process a G2H
message, but then it's quite hard to extract the content of the
broken G2H message from the captured snapshot. Extend our error
log with the raw hexdump of the G2H message.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 550eeed43903..63bd91963eb1 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1299,8 +1299,8 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)
}
if (ret) {
- xe_gt_err(gt, "G2H action 0x%04x failed (%pe)\n",
- action, ERR_PTR(ret));
+ xe_gt_err(gt, "G2H action %#04x failed (%pe) len %u msg %*ph\n",
+ action, ERR_PTR(ret), hxg_len, (int)sizeof(u32) * hxg_len, hxg);
CT_DEAD(ct, NULL, PROCESS_FAILED);
}
--
2.43.0
next prev parent reply other threads:[~2024-11-05 17:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 17:30 [PATCH 0/4] GuC: Improve handling of the malformed G2H Michal Wajdeczko
2024-11-05 17:30 ` Michal Wajdeczko [this message]
2024-11-05 19:30 ` [PATCH 1/4] drm/xe/guc: Log content of the failed G2H message Matthew Brost
2024-11-05 17:30 ` [PATCH 2/4] drm/xe/guc: Drop redundant logs about invalid G2H length Michal Wajdeczko
2024-11-05 19:31 ` Matthew Brost
2024-11-05 17:30 ` [PATCH 3/4] drm/xe/guc: Don't read data from G2H prior to length check Michal Wajdeczko
2024-11-05 19:36 ` Matthew Brost
2024-11-05 20:01 ` Michal Wajdeczko
2024-11-06 1:32 ` Matthew Brost
2024-11-05 17:30 ` [PATCH 4/4] drm/xe/guc: Don't treat GuC generic CAT error as protocol error Michal Wajdeczko
2024-11-05 20:13 ` Michal Wajdeczko
2024-11-05 20:45 ` [PATCH v2 " Michal Wajdeczko
2024-11-06 1:24 ` Matthew Brost
2024-11-05 17:38 ` ✓ CI.Patch_applied: success for GuC: Improve handling of the malformed G2H Patchwork
2024-11-05 17:38 ` ✓ CI.checkpatch: " Patchwork
2024-11-05 17:39 ` ✓ CI.KUnit: " Patchwork
2024-11-05 17:52 ` ✓ CI.Build: " Patchwork
2024-11-05 17:54 ` ✓ CI.Hooks: " Patchwork
2024-11-05 17:56 ` ✓ CI.checksparse: " Patchwork
2024-11-05 18:37 ` ✓ CI.BAT: " Patchwork
2024-11-05 20:51 ` ✓ CI.Patch_applied: success for GuC: Improve handling of the malformed G2H (rev2) Patchwork
2024-11-05 20:52 ` ✓ CI.checkpatch: " Patchwork
2024-11-05 20:53 ` ✓ CI.KUnit: " Patchwork
2024-11-05 21:04 ` ✓ CI.Build: " Patchwork
2024-11-05 21:07 ` ✓ CI.Hooks: " Patchwork
2024-11-05 21:08 ` ✓ CI.checksparse: " Patchwork
2024-11-05 21:36 ` ✓ CI.BAT: " Patchwork
2024-11-06 22:55 ` ✗ CI.FULL: failure for GuC: Improve handling of the malformed G2H Patchwork
2024-11-07 1:06 ` ✗ CI.FULL: failure for GuC: Improve handling of the malformed G2H (rev2) Patchwork
2024-11-07 9:21 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105173032.1947-2-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox