Re: [PATCH 1/4] drm/xe/guc: Log content of the failed G2H message

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Nov 05, 2024 at 06:30:29PM +0100, Michal Wajdeczko wrote:
> We are already logging an error once we failed to process a G2H
> message, but then it's quite hard to extract the content of the
> broken G2H message from the captured snapshot. Extend our error
> log with the raw hexdump of the G2H message.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_ct.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index 550eeed43903..63bd91963eb1 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -1299,8 +1299,8 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)
>  	}
>  
>  	if (ret) {
> -		xe_gt_err(gt, "G2H action 0x%04x failed (%pe)\n",
> -			  action, ERR_PTR(ret));
> +		xe_gt_err(gt, "G2H action %#04x failed (%pe) len %u msg %*ph\n",
> +			  action, ERR_PTR(ret), hxg_len, (int)sizeof(u32) * hxg_len, hxg);
>  		CT_DEAD(ct, NULL, PROCESS_FAILED);
>  	}
>  
> -- 
> 2.43.0
>