Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: "Maarten Lankhorst" <dev@lankhorst.se>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Vinod Govindapillai" <vinod.govindapillai@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>
Subject: [PATCH 02/11] drm/xe: Remove double pageflip
Date: Tue, 10 Dec 2024 09:31:02 +0100	[thread overview]
Message-ID: <20241210083111.230484-3-dev@lankhorst.se> (raw)
In-Reply-To: <20241210083111.230484-1-dev@lankhorst.se>

This is already handled below by fixup_initial_plane_config.

Fixes: a8153627520a ("drm/i915: Try to relocate the BIOS fb to the start of ggtt")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index a22e7adfb09d9..41103571b870b 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -211,8 +211,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 		to_intel_plane(crtc->base.primary);
 	struct intel_plane_state *plane_state =
 		to_intel_plane_state(plane->base.state);
-	struct intel_crtc_state *crtc_state =
-		to_intel_crtc_state(crtc->base.state);
 	struct drm_framebuffer *fb;
 	struct i915_vma *vma;
 
@@ -258,14 +256,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 	atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
 	plane_config->vma = vma;
-
-	/*
-	 * Flip to the newly created mapping ASAP, so we can re-use the
-	 * first part of GGTT for WOPCM, prevent flickering, and prevent
-	 * the lookup of sysmem scratch pages.
-	 */
-	plane->check_plane(crtc_state, plane_state);
-	plane->async_flip(NULL, plane, crtc_state, plane_state, true);
 	return;
 
 nofb:
-- 
2.45.2


  parent reply	other threads:[~2024-12-10  8:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  8:31 [PATCH 00/11] GuC changes for flicker-free boot Maarten Lankhorst
2024-12-10  8:31 ` [PATCH 01/11] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-12-12 14:33   ` Rodrigo Vivi
2024-12-10  8:31 ` Maarten Lankhorst [this message]
2024-12-10  8:31 ` [PATCH 03/11] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-12-10  8:31 ` [PATCH 04/11] drm/xe: Defer irq init until after xe_display_init_noaccel Maarten Lankhorst
2024-12-10 18:06   ` Levi, Ilia
2024-12-10  8:31 ` [PATCH 05/11] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-12-10  8:31 ` [PATCH 06/11] drm/xe: Defer memirq init until needed Maarten Lankhorst
2024-12-10 14:30   ` Lucas De Marchi
2024-12-10 18:02     ` Levi, Ilia
2024-12-10  8:31 ` [PATCH 07/11] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst
2024-12-12 14:34   ` Rodrigo Vivi
2024-12-10  8:31 ` [PATCH 08/11] drm/xe: Simplify GuC early initialisation Maarten Lankhorst
2024-12-10 15:18   ` Lucas De Marchi
2024-12-10  8:31 ` [PATCH 09/11] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2024-12-12 14:35   ` Rodrigo Vivi
2024-12-12 22:12     ` Matt Roper
2024-12-10  8:31 ` [PATCH 10/11] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2024-12-10 15:25   ` Lucas De Marchi
2024-12-11 18:52     ` Maarten Lankhorst
2024-12-13  0:36       ` Lucas De Marchi
2024-12-10  8:31 ` [PATCH 11/11] drm/xe: Do not attempt to bootstrap VF in execlists mode Maarten Lankhorst
2024-12-10 15:27   ` Lucas De Marchi
2024-12-10  8:37 ` ✓ CI.Patch_applied: success for GuC changes for flicker-free boot Patchwork
2024-12-10  8:38 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-10  8:39 ` ✓ CI.KUnit: success " Patchwork
2024-12-10  8:57 ` ✓ CI.Build: " Patchwork
2024-12-10  8:59 ` ✓ CI.Hooks: " Patchwork
2024-12-10  9:01 ` ✓ CI.checksparse: " Patchwork
2024-12-10  9:27 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-10 10:20 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-21 12:10 ` [PATCH 00/11] " Jani Nikula
2025-01-21 12:53   ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210083111.230484-3-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox