Re: [PATCH 00/11] GuC changes for flicker-free boot.

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 10 Dec 2024, Maarten Lankhorst <dev@lankhorst.se> wrote:
> Ignore the first 5 patches in this series, it's sent as a separate series.
> https://patchwork.freedesktop.org/series/142241/

For them I've replied in [1] that they need more explanations in the
commit messages.

BR,
Jani.


[1] https://lore.kernel.org/r/871pyh16pa.fsf@intel.com


> I would like review on patch 6-10 instead, those are the changes related
> to the GuC init sequence.
>
> Instead of all the separate steps, the init sequence is simplified and made
> more uniform. We create a xe_guc_init_noalloc that performs all early
> initialisation required to make VF work. We also initialise the MCR instance 0
> registers for VRAM readout, later on we enable the other MCR registers.
>
> Maarten Lankhorst (11):
>   drm/xe/display: Add intel_plane_initial_vblank_wait
>   drm/xe: Remove double pageflip
>   drm/xe: Move suballocator init to after display init
>   drm/xe: Defer irq init until after xe_display_init_noaccel
>   drm/xe/display: Use a single early init call for display
>   drm/xe: Defer memirq init until needed
>   drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init
>   drm/xe: Simplify GuC early initialisation
>   drm/xe: Make it possible to read instance0 MCR registers after
>     xe_gt_mcr_init_early
>   drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early
>   drm/xe: Do not attempt to bootstrap VF in execlists mode
>
>  drivers/gpu/drm/i915/display/intel_display.c  |  6 +-
>  .../drm/i915/display/intel_plane_initial.c    |  7 +-
>  .../drm/i915/display/intel_plane_initial.h    |  2 +
>  drivers/gpu/drm/xe/display/xe_display.c       | 73 +++++--------------
>  drivers/gpu/drm/xe/display/xe_display.h       |  8 +-
>  drivers/gpu/drm/xe/display/xe_plane_initial.c | 29 +++++---
>  drivers/gpu/drm/xe/tests/xe_guc_relay_test.c  |  2 +-
>  drivers/gpu/drm/xe/xe_device.c                | 50 +++----------
>  drivers/gpu/drm/xe/xe_gt.c                    | 73 ++++++++++---------
>  drivers/gpu/drm/xe/xe_gt.h                    |  1 -
>  drivers/gpu/drm/xe/xe_gt_mcr.c                | 47 +++++++-----
>  drivers/gpu/drm/xe/xe_gt_sriov_vf.c           |  4 +-
>  drivers/gpu/drm/xe/xe_gt_types.h              |  2 +
>  drivers/gpu/drm/xe/xe_guc.c                   | 56 ++++++++------
>  drivers/gpu/drm/xe/xe_guc.h                   |  1 +
>  drivers/gpu/drm/xe/xe_guc_ct.c                | 28 ++++---
>  drivers/gpu/drm/xe/xe_guc_ct.h                |  1 +
>  drivers/gpu/drm/xe/xe_guc_relay.c             |  6 +-
>  drivers/gpu/drm/xe/xe_guc_relay.h             |  2 +-
>  drivers/gpu/drm/xe/xe_huc.h                   |  1 +
>  drivers/gpu/drm/xe/xe_tile.c                  | 19 ++++-
>  drivers/gpu/drm/xe/xe_tile.h                  |  1 +
>  drivers/gpu/drm/xe/xe_uc.c                    | 21 ++++++
>  drivers/gpu/drm/xe/xe_uc.h                    |  1 +
>  24 files changed, 231 insertions(+), 210 deletions(-)

-- 
Jani Nikula, Intel