Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH 06/11] drm/xe: Defer memirq init until needed
Date: Tue, 10 Dec 2024 09:31:06 +0100	[thread overview]
Message-ID: <20241210083111.230484-7-dev@lankhorst.se> (raw)
In-Reply-To: <20241210083111.230484-1-dev@lankhorst.se>

memirqs require allocations into GGTT, which we cannot use until
after display is enabled.

Now that the initialisation of interrupts is postponed, move memirq
init too.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_device.c | 4 ----
 drivers/gpu/drm/xe/xe_tile.c   | 7 +++++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index c9c0b74c74ddb..4c46809472ae4 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -41,7 +41,6 @@
 #include "xe_hw_engine_group.h"
 #include "xe_hwmon.h"
 #include "xe_irq.h"
-#include "xe_memirq.h"
 #include "xe_mmio.h"
 #include "xe_module.h"
 #include "xe_oa.h"
@@ -675,9 +674,6 @@ int xe_device_probe(struct xe_device *xe)
 		err = xe_ggtt_init_early(tile->mem.ggtt);
 		if (err)
 			return err;
-		err = xe_memirq_init(&tile->memirq);
-		if (err)
-			return err;
 	}
 
 	for_each_gt(gt, xe, id) {
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 2825553b568f7..d07c1fba793ca 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -10,6 +10,7 @@
 #include "xe_device.h"
 #include "xe_ggtt.h"
 #include "xe_gt.h"
+#include "xe_memirq.h"
 #include "xe_migrate.h"
 #include "xe_pcode.h"
 #include "xe_sa.h"
@@ -179,6 +180,12 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
 
 int xe_tile_init(struct xe_tile *tile)
 {
+	int err;
+
+	err = xe_memirq_init(&tile->memirq);
+	if (err)
+		return err;
+
 	tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
 	if (IS_ERR(tile->mem.kernel_bb_pool))
 		return PTR_ERR(tile->mem.kernel_bb_pool);
-- 
2.45.2


  parent reply	other threads:[~2024-12-10  8:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  8:31 [PATCH 00/11] GuC changes for flicker-free boot Maarten Lankhorst
2024-12-10  8:31 ` [PATCH 01/11] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-12-12 14:33   ` Rodrigo Vivi
2024-12-10  8:31 ` [PATCH 02/11] drm/xe: Remove double pageflip Maarten Lankhorst
2024-12-10  8:31 ` [PATCH 03/11] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-12-10  8:31 ` [PATCH 04/11] drm/xe: Defer irq init until after xe_display_init_noaccel Maarten Lankhorst
2024-12-10 18:06   ` Levi, Ilia
2024-12-10  8:31 ` [PATCH 05/11] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-12-10  8:31 ` Maarten Lankhorst [this message]
2024-12-10 14:30   ` [PATCH 06/11] drm/xe: Defer memirq init until needed Lucas De Marchi
2024-12-10 18:02     ` Levi, Ilia
2024-12-10  8:31 ` [PATCH 07/11] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst
2024-12-12 14:34   ` Rodrigo Vivi
2024-12-10  8:31 ` [PATCH 08/11] drm/xe: Simplify GuC early initialisation Maarten Lankhorst
2024-12-10 15:18   ` Lucas De Marchi
2024-12-10  8:31 ` [PATCH 09/11] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2024-12-12 14:35   ` Rodrigo Vivi
2024-12-12 22:12     ` Matt Roper
2024-12-10  8:31 ` [PATCH 10/11] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2024-12-10 15:25   ` Lucas De Marchi
2024-12-11 18:52     ` Maarten Lankhorst
2024-12-13  0:36       ` Lucas De Marchi
2024-12-10  8:31 ` [PATCH 11/11] drm/xe: Do not attempt to bootstrap VF in execlists mode Maarten Lankhorst
2024-12-10 15:27   ` Lucas De Marchi
2024-12-10  8:37 ` ✓ CI.Patch_applied: success for GuC changes for flicker-free boot Patchwork
2024-12-10  8:38 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-10  8:39 ` ✓ CI.KUnit: success " Patchwork
2024-12-10  8:57 ` ✓ CI.Build: " Patchwork
2024-12-10  8:59 ` ✓ CI.Hooks: " Patchwork
2024-12-10  9:01 ` ✓ CI.checksparse: " Patchwork
2024-12-10  9:27 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-10 10:20 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-21 12:10 ` [PATCH 00/11] " Jani Nikula
2025-01-21 12:53   ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210083111.230484-7-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox