From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v3 00/10] PSR DSB support
Date: Thu, 9 Jan 2025 09:31:27 +0200 [thread overview]
Message-ID: <20250109073137.1977494-1-jouni.hogander@intel.com> (raw)
This patch set is doing necessary modifications to support PSR update
using DSB on LunarLake onwards
It is not necessary to wait for PSR1 to idle or PSR2 to exit DEEP
sleep at the begin of commit This is left out from DSB commit. There
might be room for optimization for non-DSB as well because such wait
is not supposed to be necessary at the begin of update.
PSR mutex is not locked when performing DSB commit. It is not
necessary as we are currently using DSB only when sending updates
towards panel. I.e. not using it when changing PSR mode. Also
necessary changes are made to use PSR2_MAN_TRK_CTL only in
DSB. Frontbuffer updates and legacy cursor updates are using SFF_CTL
register to perform full frame updates.
DSB_SKIP_WAITS_EN is kept set as otherwise DSB wait for scanline hangs
if it's entered when PSR2_STATUS[PSR2 State] == DEEP_SLEEP or
SRD_STATUS[SRD State] == SRDENT.
v3:
- do not use DSB when PSR mode is changing
v2:
- use _MMIO_TRANS instead of _MMIO_TRANS2
- drop evasion from intel_psr_configure_full_frame_update
Jouni Högander (10):
drm/i915/psr: Use PSR2_MAN_TRK_CTL CFF bit only to send full update
drm/i915/psr: Rename psr_force_hw_tracking_exit as
intel_psr_force_update
drm/i915/psr: Split setting sff and cff bits away from
intel_psr_force_update
drm/i915/psr: Add register definitions for SFF_CTL and CFF_CTL
registers
drm/i915/psr: Use SFF_CTL on invalidate/flush for LunarLake onwards
drm/i915/psr: Allow writing PSR2_MAN_TRK_CTL using DSB
drm/i915/psr: Changes for PSR2_MAN_TRK_CTL handling when DSB is in use
drm/i915/psr: Add intel_psr_is_psr_mode_changing
drm/i915/display: Don't use DSB if psr mode changing
drm/i915/psr: Allow DSB usage when PSR is enabled
drivers/gpu/drm/i915/display/intel_display.c | 11 +-
drivers/gpu/drm/i915/display/intel_psr.c | 139 +++++++++---------
drivers/gpu/drm/i915/display/intel_psr.h | 6 +-
drivers/gpu/drm/i915/display/intel_psr_regs.h | 10 ++
4 files changed, 95 insertions(+), 71 deletions(-)
--
2.43.0
next reply other threads:[~2025-01-09 7:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 7:31 Jouni Högander [this message]
2025-01-09 7:31 ` [PATCH v3 01/10] drm/i915/psr: Use PSR2_MAN_TRK_CTL CFF bit only to send full update Jouni Högander
2025-01-15 7:43 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 02/10] drm/i915/psr: Rename psr_force_hw_tracking_exit as intel_psr_force_update Jouni Högander
2025-01-15 7:46 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 03/10] drm/i915/psr: Split setting sff and cff bits away from intel_psr_force_update Jouni Högander
2025-01-15 7:58 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 04/10] drm/i915/psr: Add register definitions for SFF_CTL and CFF_CTL registers Jouni Högander
2025-01-15 8:32 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 05/10] drm/i915/psr: Use SFF_CTL on invalidate/flush for LunarLake onwards Jouni Högander
2025-01-15 8:18 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 06/10] drm/i915/psr: Allow writing PSR2_MAN_TRK_CTL using DSB Jouni Högander
2025-01-16 6:03 ` Manna, Animesh
2025-01-17 19:22 ` Ville Syrjälä
2025-01-20 6:47 ` Hogander, Jouni
2025-01-09 7:31 ` [PATCH v3 07/10] drm/i915/psr: Changes for PSR2_MAN_TRK_CTL handling when DSB is in use Jouni Högander
2025-01-16 6:10 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 08/10] drm/i915/psr: Add intel_psr_is_psr_mode_changing Jouni Högander
2025-01-16 7:15 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 09/10] drm/i915/display: Don't use DSB if psr mode changing Jouni Högander
2025-01-16 7:19 ` Manna, Animesh
2025-01-09 7:31 ` [PATCH v3 10/10] drm/i915/psr: Allow DSB usage when PSR is enabled Jouni Högander
2025-01-16 7:27 ` Manna, Animesh
2025-01-17 20:20 ` Ville Syrjälä
2025-01-17 23:07 ` Ville Syrjälä
2025-01-20 7:28 ` Hogander, Jouni
2025-01-20 14:39 ` Ville Syrjälä
2025-01-20 15:27 ` Ville Syrjälä
2025-01-21 10:29 ` Hogander, Jouni
2025-01-21 13:57 ` Ville Syrjälä
2025-01-21 15:11 ` Ville Syrjälä
2025-01-22 5:53 ` Hogander, Jouni
2025-01-09 7:46 ` ✓ CI.Patch_applied: success for PSR DSB support (rev3) Patchwork
2025-01-09 7:46 ` ✓ CI.checkpatch: " Patchwork
2025-01-09 7:47 ` ✓ CI.KUnit: " Patchwork
2025-01-09 8:05 ` ✓ CI.Build: " Patchwork
2025-01-09 8:07 ` ✓ CI.Hooks: " Patchwork
2025-01-09 8:09 ` ✗ CI.checksparse: warning " Patchwork
2025-01-09 8:38 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-11 11:27 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109073137.1977494-1-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox