Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/guc: Drop error messages about missing GuC logs
@ 2025-01-13 19:44 John.C.Harrison
  2025-01-13 19:59 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: John.C.Harrison @ 2025-01-13 19:44 UTC (permalink / raw)
  To: Intel-Xe; +Cc: John Harrison

From: John Harrison <John.C.Harrison@Intel.com>

The GuC log snapshot code would complain loudly if there was no GuC
log to take a snapshot of or if the snapshot alloc failed. Originally,
this code was only called on demand when a user (or developer)
explicitly requested a dump of the log. Hence an error message was
useful.

However, it is now part of the general devcoredump file and is called
for any GPU hang. Most people don't care about GuC logs and GPU hangs
do not generally mean a kernel/GuC bug. More importantly, there are
valid situations where there is no GuC log, e.g. SRIOV VFs.

So drop the error message.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3958
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/xe/xe_guc_log.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
index df4cfb698cdb..80151ff6a71f 100644
--- a/drivers/gpu/drm/xe/xe_guc_log.c
+++ b/drivers/gpu/drm/xe/xe_guc_log.c
@@ -149,16 +149,12 @@ struct xe_guc_log_snapshot *xe_guc_log_snapshot_capture(struct xe_guc_log *log,
 	size_t remain;
 	int i;
 
-	if (!log->bo) {
-		xe_gt_err(gt, "GuC log buffer not allocated\n");
+	if (!log->bo)
 		return NULL;
-	}
 
 	snapshot = xe_guc_log_snapshot_alloc(log, atomic);
-	if (!snapshot) {
-		xe_gt_err(gt, "GuC log snapshot not allocated\n");
+	if (!snapshot)
 		return NULL;
-	}
 
 	remain = snapshot->size;
 	for (i = 0; i < snapshot->num_chunks; i++) {
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2025-01-15  3:00 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-13 19:44 [PATCH] drm/xe/guc: Drop error messages about missing GuC logs John.C.Harrison
2025-01-13 19:59 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-13 19:59 ` ✓ CI.checkpatch: " Patchwork
2025-01-13 20:00 ` ✓ CI.KUnit: " Patchwork
2025-01-13 20:18 ` ✓ CI.Build: " Patchwork
2025-01-13 20:21 ` ✓ CI.Hooks: " Patchwork
2025-01-13 20:22 ` ✓ CI.checksparse: " Patchwork
2025-01-13 20:32 ` [PATCH] " Rodrigo Vivi
2025-01-13 20:50 ` ✗ Xe.CI.BAT: failure for " Patchwork
2025-01-14  9:50 ` ✗ Xe.CI.Full: " Patchwork
2025-01-14 22:50 ` ✓ CI.Patch_applied: success for drm/xe/guc: Drop error messages about missing GuC logs (rev2) Patchwork
2025-01-14 22:50 ` ✓ CI.checkpatch: " Patchwork
2025-01-14 22:52 ` ✓ CI.KUnit: " Patchwork
2025-01-14 23:11 ` ✓ CI.Build: " Patchwork
2025-01-14 23:13 ` ✓ CI.Hooks: " Patchwork
2025-01-14 23:15 ` ✓ CI.checksparse: " Patchwork
2025-01-14 23:41 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-15  3:00 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox