Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, uma.shankar@intel.com,
	ville.syrjala@linux.intel.com
Subject: [PATCH v6 3/6] drm/i915/dp: fix the Adaptive sync Operation mode for SDP
Date: Thu, 30 Jan 2025 10:46:06 +0530	[thread overview]
Message-ID: <20250130051609.1796524-4-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20250130051609.1796524-1-mitulkumar.ajitkumar.golani@intel.com>

From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Currently we support Adaptive sync operation mode with dynamic frame
rate, but instead the operation mode with fixed rate is set.
This was initially set correctly in the earlier version of changes but
later got changed, while defining a macro for the same.

Fixes: a5bd5991cb8a ("drm/i915/display: Compute AS SDP parameters")
Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index a286e5e31c4d..591e4fa20c16 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2831,7 +2831,6 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
 
 	crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
 
-	/* Currently only DP_AS_SDP_AVT_FIXED_VTOTAL mode supported */
 	as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC;
 	as_sdp->length = 0x9;
 	as_sdp->duration_incr_ms = 0;
@@ -2842,7 +2841,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
 		as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode);
 		as_sdp->target_rr_divider = true;
 	} else {
-		as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL;
+		as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
 		as_sdp->vtotal = adjusted_mode->vtotal;
 		as_sdp->target_rr = 0;
 	}
-- 
2.48.1


  parent reply	other threads:[~2025-01-30  5:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  5:16 [PATCH v6 0/6] Add AS_SDP to fastset Mitul Golani
2025-01-30  5:16 ` [PATCH v6 1/6] drm/i915/vrr: Add crtc_state dump for vrr.vsync params Mitul Golani
2025-01-30  5:16 ` [PATCH v6 2/6] drm/i915/vrr: Compute vrr.vsync_{start, end} during full modeset Mitul Golani
2025-01-30  5:16 ` Mitul Golani [this message]
2025-01-30  5:16 ` [PATCH v6 4/6] drm/i915/dp: Compute as_sdp.vtotal based on vrr timings Mitul Golani
2025-01-30  5:16 ` [PATCH v6 5/6] drm/i915/dp: Compute as_sdp based on if vrr possible Mitul Golani
2025-01-30  6:14   ` Nautiyal, Ankit K
2025-01-30  5:16 ` [PATCH v6 6/6] drm/i915/display: Move as sdp params change to fastset Mitul Golani
2025-01-30  6:15   ` Nautiyal, Ankit K
2025-01-30  5:26 ` ✓ CI.Patch_applied: success for Add AS_SDP to fastset (rev3) Patchwork
2025-01-30  5:26 ` ✓ CI.checkpatch: " Patchwork
2025-01-30  5:28 ` ✓ CI.KUnit: " Patchwork
2025-01-30  5:44 ` ✓ CI.Build: " Patchwork
2025-01-30  5:46 ` ✓ CI.Hooks: " Patchwork
2025-01-30  5:48 ` ✓ CI.checksparse: " Patchwork
2025-01-30  6:08 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-30  8:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-30  8:59   ` Golani, Mitulkumar Ajitkumar
2025-01-30 14:37 ` [PATCH v6 0/6] Add AS_SDP to fastset Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250130051609.1796524-4-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox