Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
	<intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>
Cc: <uma.shankar@intel.com>, <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v6 6/6] drm/i915/display: Move as sdp params change to fastset
Date: Thu, 30 Jan 2025 11:45:15 +0530	[thread overview]
Message-ID: <d2911efc-10fc-4e51-a72b-e3e2c946f421@intel.com> (raw)
In-Reply-To: <20250130051609.1796524-7-mitulkumar.ajitkumar.golani@intel.com>


On 1/30/2025 10:46 AM, Mitul Golani wrote:
> as_sdp param changes from vrr to cmrr should happen to fastset.
> Changing as_sdp params should not trigger any modeset.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 7d68d652c1bc..60867b5b03ec 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5752,10 +5752,11 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   	PIPE_CONF_CHECK_INFOFRAME(avi);
>   	PIPE_CONF_CHECK_INFOFRAME(spd);
>   	PIPE_CONF_CHECK_INFOFRAME(hdmi);
> -	if (!fastset)
> +	if (!fastset) {
>   		PIPE_CONF_CHECK_INFOFRAME(drm);
> +		PIPE_CONF_CHECK_DP_AS_SDP(as_sdp);
> +	}
>   	PIPE_CONF_CHECK_DP_VSC_SDP(vsc);
> -	PIPE_CONF_CHECK_DP_AS_SDP(as_sdp);
>   
>   	PIPE_CONF_CHECK_X(sync_mode_slaves_mask);
>   	PIPE_CONF_CHECK_I(master_transcoder);

  reply	other threads:[~2025-01-30  6:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  5:16 [PATCH v6 0/6] Add AS_SDP to fastset Mitul Golani
2025-01-30  5:16 ` [PATCH v6 1/6] drm/i915/vrr: Add crtc_state dump for vrr.vsync params Mitul Golani
2025-01-30  5:16 ` [PATCH v6 2/6] drm/i915/vrr: Compute vrr.vsync_{start, end} during full modeset Mitul Golani
2025-01-30  5:16 ` [PATCH v6 3/6] drm/i915/dp: fix the Adaptive sync Operation mode for SDP Mitul Golani
2025-01-30  5:16 ` [PATCH v6 4/6] drm/i915/dp: Compute as_sdp.vtotal based on vrr timings Mitul Golani
2025-01-30  5:16 ` [PATCH v6 5/6] drm/i915/dp: Compute as_sdp based on if vrr possible Mitul Golani
2025-01-30  6:14   ` Nautiyal, Ankit K
2025-01-30  5:16 ` [PATCH v6 6/6] drm/i915/display: Move as sdp params change to fastset Mitul Golani
2025-01-30  6:15   ` Nautiyal, Ankit K [this message]
2025-01-30  5:26 ` ✓ CI.Patch_applied: success for Add AS_SDP to fastset (rev3) Patchwork
2025-01-30  5:26 ` ✓ CI.checkpatch: " Patchwork
2025-01-30  5:28 ` ✓ CI.KUnit: " Patchwork
2025-01-30  5:44 ` ✓ CI.Build: " Patchwork
2025-01-30  5:46 ` ✓ CI.Hooks: " Patchwork
2025-01-30  5:48 ` ✓ CI.checksparse: " Patchwork
2025-01-30  6:08 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-30  8:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-30  8:59   ` Golani, Mitulkumar Ajitkumar
2025-01-30 14:37 ` [PATCH v6 0/6] Add AS_SDP to fastset Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2911efc-10fc-4e51-a72b-e3e2c946f421@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox