Re: [PATCH v6 5/6] drm/i915/dp: Compute as_sdp based on if vrr possible

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 1/30/2025 10:46 AM, Mitul Golani wrote:
> Adaptive sync sdp param computation, we can configure during
> full modeset as well when sink is having vrr support, where
> it doesn't need dependency on vrr.enable status and can also
> match vrr enable/disable fastset requirement.
>
> --v2:
>   - Separate the change from as_sdp.vtotal. [Ankit]
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>

LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index f876dbeb6121..80214a559013 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2826,7 +2826,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
>   	const struct drm_display_mode *adjusted_mode =
>   		&crtc_state->hw.adjusted_mode;
>   
> -	if (!crtc_state->vrr.enable || !intel_dp->as_sdp_supported)
> +	if (!intel_vrr_possible(crtc_state) || !intel_dp->as_sdp_supported)
>   		return;
>   
>   	crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);