From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: intel-xe@lists.freedesktop.org
Cc: kernel-dev@igalia.com, Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Matt Roper <matthew.d.roper@intel.com>,
Gustavo Sousa <gustavo.sousa@intel.com>
Subject: [PATCH 3/5] drm/xe/xelp: Add Wa_1604555607
Date: Thu, 27 Feb 2025 10:13:02 +0000 [thread overview]
Message-ID: <20250227101304.46660-4-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20250227101304.46660-1-tvrtko.ursulin@igalia.com>
According to the i915 code base and as confirmed in the workaround
database, apart from setting the GS timer, all XeLP platforms should also
set the TDS timer.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
References: 2b5298b0aa09 ("drm/i915/gen12: Add recommended hardware tuning value")
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
---
drivers/gpu/drm/xe/xe_wa.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
index e446bde3a52b..398bfd0984c2 100644
--- a/drivers/gpu/drm/xe/xe_wa.c
+++ b/drivers/gpu/drm/xe/xe_wa.c
@@ -631,6 +631,13 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
FF_MODE2_GS_TIMER_MASK,
FF_MODE2_GS_TIMER_224))
},
+ { XE_RTP_NAME("1604555607"),
+ XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210), ENGINE_CLASS(RENDER)),
+ /* read verification is ignored due to 1608008084. */
+ XE_RTP_ACTIONS(FIELD_SET_NO_READ_MASK(FF_MODE2,
+ FF_MODE2_TDS_TIMER_MASK,
+ FF_MODE2_TDS_TIMER_128))
+ },
{ XE_RTP_NAME("1409342910, 14010698770, 14010443199, 1408979724, 1409178076, 1409207793, 1409217633, 1409252684, 1409347922, 1409142259"),
XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210)),
XE_RTP_ACTIONS(SET(COMMON_SLICE_CHICKEN3,
--
2.48.0
next prev parent reply other threads:[~2025-02-27 10:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 10:12 [PATCH v4 0/5] Workaround fixes, improvements, additions Tvrtko Ursulin
2025-02-27 10:13 ` [PATCH 1/5] drm/xe: Fix GT "for each engine" workarounds Tvrtko Ursulin
2025-02-27 10:13 ` [PATCH 2/5] drm/xe/xelp: Move Wa_16011163337 from tunings to workarounds Tvrtko Ursulin
2025-02-27 20:58 ` Lucas De Marchi
2025-02-28 8:08 ` Tvrtko Ursulin
2025-03-01 0:55 ` Lucas De Marchi
2025-02-27 10:13 ` Tvrtko Ursulin [this message]
2025-02-27 21:13 ` [PATCH 3/5] drm/xe/xelp: Add Wa_1604555607 Matt Roper
2025-02-27 21:13 ` Lucas De Marchi
2025-02-27 10:13 ` [PATCH 4/5] drm/xe/xelp: L3 recommended hashing mask Tvrtko Ursulin
2025-02-27 21:16 ` Lucas De Marchi
2025-02-27 21:21 ` Matt Roper
2025-03-01 5:48 ` Lucas De Marchi
2025-03-03 16:28 ` Tvrtko Ursulin
2025-02-27 10:13 ` [PATCH 5/5] drm/xe: Add performance tunings to debugfs Tvrtko Ursulin
2025-02-27 10:54 ` ✓ CI.Patch_applied: success for Workaround fixes, improvements, additions (rev4) Patchwork
2025-02-27 10:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-27 10:55 ` ✓ CI.KUnit: success " Patchwork
2025-02-27 11:12 ` ✓ CI.Build: " Patchwork
2025-02-27 11:15 ` ✓ CI.Hooks: " Patchwork
2025-02-27 11:16 ` ✓ CI.checksparse: " Patchwork
2025-02-27 11:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-27 13:52 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227101304.46660-4-tvrtko.ursulin@igalia.com \
--to=tvrtko.ursulin@igalia.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kernel-dev@igalia.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox